From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56108: 29.0.50; ASAN use-after-free in re_match_2_internal Date: Thu, 23 Jun 2022 10:17:17 +0300 Message-ID: <831qvfg876.fsf@gnu.org> References: <83mte7kv7c.fsf@gnu.org> <32e548cc-ffd3-4669-ad9a-317c130b0c93@Spark> <83a6a4kec0.fsf@gnu.org> <6e56407a-b564-4aa9-b74c-78883727ef09@Spark> <831qvgkc8d.fsf@gnu.org> <83sfnwisbb.fsf@gnu.org> <3146c990-63d9-4aa5-ab78-7bae2b7d6cd5@Spark> <835ykrg93i.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23916"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 56108@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 23 09:18:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4H6h-00064M-0b for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Jun 2022 09:18:27 +0200 Original-Received: from localhost ([::1]:46082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4H6f-00057E-PK for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Jun 2022 03:18:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4H6I-00056A-NZ for bug-gnu-emacs@gnu.org; Thu, 23 Jun 2022 03:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43214) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4H6I-0001Xk-DH for bug-gnu-emacs@gnu.org; Thu, 23 Jun 2022 03:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o4H6I-0005CX-9V for bug-gnu-emacs@gnu.org; Thu, 23 Jun 2022 03:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jun 2022 07:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56108 X-GNU-PR-Package: emacs Original-Received: via spool by 56108-submit@debbugs.gnu.org id=B56108.165596865619962 (code B ref 56108); Thu, 23 Jun 2022 07:18:02 +0000 Original-Received: (at 56108) by debbugs.gnu.org; 23 Jun 2022 07:17:36 +0000 Original-Received: from localhost ([127.0.0.1]:37111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4H5s-0005Bu-HW for submit@debbugs.gnu.org; Thu, 23 Jun 2022 03:17:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4H5q-0005Bh-1g for 56108@debbugs.gnu.org; Thu, 23 Jun 2022 03:17:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4H5j-0001V2-P1; Thu, 23 Jun 2022 03:17:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=G7BacGWLnG05Sq8+toSPrfGZiKClTkfcgpsdui1Wg58=; b=Bv0S2wM06wD+ IMO9Sdkw/JwW5xlIzbLzFuXaKufQDXCvyej72BMZThM+fV53b3BFepJI1lf41SwFWkOVQEYXqfP6v w6Ai+dsFJdHX3jhCyjsxXX1/zelvcZE4OwbfQZDC7Tn5HXfgzOcsBy9jA5/GC+YdxxVxNDNnvGkfU iJGdjyMxQ0Zq7xd1burVQ9fpMVu0kNLUSC1JCOOP8TEvpfceWUe1kHZSUtfNznYLgYufcyXhsAUUV fTRYQaaSUeukuFrE5CPw0WWuVJGdc0siOBX4vhzSkGyIj19KeMydLvJQYrNF+TOsY530ui2Lh6OjN dp6oVBdjjZqIxGTvezgWKw==; Original-Received: from [87.69.77.57] (port=2288 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4H5j-0008RD-1y; Thu, 23 Jun 2022 03:17:27 -0400 In-Reply-To: <835ykrg93i.fsf@gnu.org> (message from Eli Zaretskii on Thu, 23 Jun 2022 09:57:53 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235069 Archived-At: > Cc: 56108@debbugs.gnu.org > Date: Thu, 23 Jun 2022 09:57:53 +0300 > From: Eli Zaretskii > > > Do you want to do that or should I? > > Feel free to do it, I generally prefer that people who see the problem > and could at least potentially test the solution also make the change > to fix it. Actually, let's first bring Stefan on board of this discussion. Stefan, do you happen to know why some of the callers of compile_pattern don't call freeze_pattern to protect the new cache entry? Is it just an omission or do we miss something here?