From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56210: 29.0.50; Keyboard macros do not trigger after-change-functions Date: Mon, 27 Jun 2022 19:54:36 +0300 Message-ID: <831qva82sz.fsf@gnu.org> References: <8735ftklkr.fsf@gnus.org> <83pmiwa7y3.fsf@gnu.org> <83fsjralpq.fsf@gnu.org> <70bed502-1c51-8cd6-68b1-16c4e3c410e0@rhansen.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25208"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56210@debbugs.gnu.org, larsi@gnus.org To: Richard Hansen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 27 19:16:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5sLK-0006Kr-Jl for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Jun 2022 19:16:10 +0200 Original-Received: from localhost ([::1]:46982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5sLJ-0006zt-5G for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Jun 2022 13:16:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5s0t-0000sy-7a for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 12:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59232) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5s0s-0008Sl-UZ for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 12:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5s0r-0000HO-Tn for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 12:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Jun 2022 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56210 X-GNU-PR-Package: emacs Original-Received: via spool by 56210-submit@debbugs.gnu.org id=B56210.16563488821047 (code B ref 56210); Mon, 27 Jun 2022 16:55:01 +0000 Original-Received: (at 56210) by debbugs.gnu.org; 27 Jun 2022 16:54:42 +0000 Original-Received: from localhost ([127.0.0.1]:53129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5s0Y-0000Gp-2j for submit@debbugs.gnu.org; Mon, 27 Jun 2022 12:54:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5s0W-0000Gc-RT for 56210@debbugs.gnu.org; Mon, 27 Jun 2022 12:54:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5s0R-0008Ql-7Z; Mon, 27 Jun 2022 12:54:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=voFH8QCltpkBsIRMmhMKJR1aq91MM3O3zD3ImRK9GVg=; b=bKhzYamNRB4Q 5qf6b7PvfZzhL6GxASPeyxQp5sjDNHMsdtbARl874iYjFLujLro9RKjhRVSpkvU5NeqOf/llTA0Nv y7mimCEmg5moVW1SMJRTmn7RQAKRvD1RNAhVatz8lTN9nCFqjy+7XmaYND5S/HApE+2gGf5NeBWLf +rrvouI635veDR3IRPWI7xo2v7WrJLKxY/Sjk2rLWqYCSf11JmapEOEeqTVQld4NziD7fWnWc/vgG v7ZbutRirHpoWeU7PnVCsrNYL2yeAr/znnnpmYm0EsZjdAAgv/OfLtlVeP+BJ8I8IYbHMRyw/S/2f AXDVwVJXahXfjLtAT6nxug==; Original-Received: from [87.69.77.57] (port=4090 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5s0Q-0005uT-No; Mon, 27 Jun 2022 12:54:35 -0400 In-Reply-To: <70bed502-1c51-8cd6-68b1-16c4e3c410e0@rhansen.org> (message from Richard Hansen on Sun, 26 Jun 2022 23:21:24 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235485 Archived-At: > Date: Sun, 26 Jun 2022 23:21:24 -0400 > Cc: larsi@gnus.org, 56210@debbugs.gnu.org > From: Richard Hansen > > > Is the temporary buffer indeed modified, and is the hook set in that > > buffer? > > Yes on both accounts. See updated test below. > > I changed the test to switch to the temporary buffer in the selected window and it now reliably inserts "x" into the temporary buffer. It still doesn't run the `after-change-functions' hook, however. Updated test code: > > ;; -*- lexical-binding: t; -*- > (require 'ert) > (require 'ert-x) > (defvar-local acf 0) > (defun acf (&rest _) (setq-local acf (1+ acf))) > (ert-deftest test () > (ert-with-test-buffer () > (let ((b (current-buffer))) > (save-window-excursion > (with-current-buffer-window b > `(display-buffer-below-selected > (body-function > . ,(lambda (window) > (select-window window t) > (should (eq (current-buffer) b)) > (setq-local acf 0) > ;; Note that LOCAL is t: > (add-hook 'after-change-functions #'acf nil t) > (should (memq #'acf after-change-functions)) > (execute-kbd-macro (kbd "x")) > (should (equal (buffer-string) "x")) > ;; The above checks pass, this check fails: > (should (equal acf 1))))) > nil))))) Your test calls with-current-buffer-window, which calls temp-buffer-window-setup, which inhibits modification hooks: (defun temp-buffer-window-setup (buffer-or-name) "Set up temporary buffer specified by BUFFER-OR-NAME. Return the buffer." (let ((old-dir default-directory) (buffer (get-buffer-create buffer-or-name))) (with-current-buffer buffer (kill-all-local-variables) (setq default-directory old-dir) (delete-all-overlays) (setq buffer-read-only nil) (setq buffer-file-name nil) (setq buffer-undo-list t) (let ((inhibit-read-only t) (inhibit-modification-hooks t)) <<<<<<<<<<<<<<<<<<<<<< (erase-buffer) (run-hooks 'temp-buffer-window-setup-hook)) ;; Return the buffer. buffer)))