From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode Date: Fri, 08 Jul 2022 15:59:53 +0300 Message-ID: <831quv4v5i.fsf@gnu.org> References: <874jzui52r.fsf@web.de> <87iloa2hlm.fsf@web.de> <87mtdmyrp4.fsf@web.de> <83o7y15vtz.fsf@gnu.org> <87edyxz0as.fsf@web.de> <83czeh5hy9.fsf@gnu.org> <87bku15g5e.fsf@web.de> <835yk959w4.fsf@gnu.org> <87sfndufh3.fsf@web.de> <87o7y1uf03.fsf@web.de> <83y1x452r7.fsf@gnu.org> <875yk795fd.fsf@web.de> <83a69j4wwc.fsf@gnu.org> <871quv92yp.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5911"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56423@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 08 15:05:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9nfw-0001LT-7I for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Jul 2022 15:05:40 +0200 Original-Received: from localhost ([::1]:54884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9nfv-0000bf-5n for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Jul 2022 09:05:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56834) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9nbT-0005rU-85 for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2022 09:01:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9nbS-0003vY-Ip for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2022 09:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9nbS-0002Ea-HP for bug-gnu-emacs@gnu.org; Fri, 08 Jul 2022 09:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Jul 2022 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56423 X-GNU-PR-Package: emacs Original-Received: via spool by 56423-submit@debbugs.gnu.org id=B56423.16572852108304 (code B ref 56423); Fri, 08 Jul 2022 13:01:02 +0000 Original-Received: (at 56423) by debbugs.gnu.org; 8 Jul 2022 13:00:10 +0000 Original-Received: from localhost ([127.0.0.1]:59080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9nab-00029s-Ja for submit@debbugs.gnu.org; Fri, 08 Jul 2022 09:00:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9naW-00028V-MR for 56423@debbugs.gnu.org; Fri, 08 Jul 2022 09:00:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42186) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9naR-0003R0-01; Fri, 08 Jul 2022 08:59:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yls/Vholn4/+dFp4+PV5YrCw0jTO7620xaCdyLFZQbk=; b=d8pWhL7ZrUrI XRdvSkHADnsol/2Hnhyp7V2nI68e+UD320XKnfpDhcUs4NnqBf72vNaytEJAC7j/W2C6JwkJwh3p8 NmuGCZ6Tg4Uhm3mbZMRg7xKu8DmVhq7Ofq9pfIxoOqq5Yv479Smc+hoiXO8RsSHDQ5tE71M/OzYSm 0N3Khww7a6HCBP51sMw8VO8QyUTjjd/xVZCakNOUAkKWCFk1OYFVL901n2A/WdJhvikgcoWW7jFHJ fTEATmi07BovQNk+YYC9Jx1urTgTNBydOOYKuQ6D1XIqlH9lKA8h3rLMuODx8m/BLwt6inK8P0/rr I5HiE1O9WQvdo7cRNpeARA==; Original-Received: from [87.69.77.57] (port=3511 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9naM-0001NA-Fl; Fri, 08 Jul 2022 08:59:56 -0400 In-Reply-To: <871quv92yp.fsf@web.de> (message from Michael Heerdegen on Fri, 08 Jul 2022 14:57:34 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236452 Archived-At: > From: Michael Heerdegen > Cc: 56423@debbugs.gnu.org > Date: Fri, 08 Jul 2022 14:57:34 +0200 > > Eli Zaretskii writes: > > > You mean, the display will no longer match the actual situation on > > disk? Then I think an unwind-protect or condition-case form that > > resyncs the display in case of a signal is in order, since preventing > > the user from aborting in that place would be wrong -- what if the > > user realizes, too late, that some of the changes mean trouble? > > The question is how to unwind. I guess the only sensible action would > be to revert the dired buffer, since we can't revert partial file > changes, and the situation could look differently in many different > ways. Yes, I think reverting is TRT here, since (AFAIU) the display will then reflect what was actually changed and what wasn't.