From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56606: Acknowledgement (29.0.50; recent master fails with "creating pipe: too many open files") Date: Sun, 17 Jul 2022 15:46:53 +0300 Message-ID: <831qujrjnm.fsf@gnu.org> References: <86ilnwafso.fsf@stephe-leake.org> <86a6989itv.fsf@stephe-leake.org> <8335f0qbvn.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9772"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56606@debbugs.gnu.org To: stephen_leake@stephe-leake.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 17 14:49:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oD3hz-0002LJ-8G for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Jul 2022 14:49:15 +0200 Original-Received: from localhost ([::1]:56346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oD3hy-00038E-7L for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Jul 2022 08:49:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oD3go-0001tq-Up for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 08:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oD3go-0008VQ-Lm for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 08:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oD3go-0006bO-G4 for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2022 08:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Jul 2022 12:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56606 X-GNU-PR-Package: emacs Original-Received: via spool by 56606-submit@debbugs.gnu.org id=B56606.165806203725213 (code B ref 56606); Sun, 17 Jul 2022 12:48:02 +0000 Original-Received: (at 56606) by debbugs.gnu.org; 17 Jul 2022 12:47:17 +0000 Original-Received: from localhost ([127.0.0.1]:46856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oD3g4-0006Yb-OO for submit@debbugs.gnu.org; Sun, 17 Jul 2022 08:47:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oD3g2-0006YO-PF for 56606@debbugs.gnu.org; Sun, 17 Jul 2022 08:47:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45552) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oD3fx-0008Fl-B9; Sun, 17 Jul 2022 08:47:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nV5Z8D2769JBxTAKhHw4BeEU79t/bTd94lNAucLjFnk=; b=CMhQxsUif/3w CbhERSleHPPCp1FocwS9rvUQsIF+WqzKnhu2aDWL4/8pYnp+brs5XaW8QcVqhDywFepBmLQofIICw zl0x2rv7J2I4FN63/263stBsuAwZjnzO1L8g7qYrJbHXPCrL43ng7EKXe+iE+xWJnKj+m8DE1Iqua 6k9+01Cf1S+Z2GBpus8We4SuEYKFwCC8XKSY89F3aOu9tIEMZzkNyta7xvZD7vc0PICoXZIUshmPx B7X+hbgeYwDd7h6IMYNBENQo2UPIKQI/zxcYFdin3BKpbM0NUSB6qGShL/U8+EKrA0dd9o+Q3OZis KmP42oDxIdTs6tMDH4bHYQ==; Original-Received: from [87.69.77.57] (port=3792 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oD3fw-0000mJ-Qy; Sun, 17 Jul 2022 08:47:09 -0400 In-Reply-To: <8335f0qbvn.fsf@gnu.org> (message from Eli Zaretskii on Sun, 17 Jul 2022 13:20:12 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237261 Archived-At: > Cc: 56606@debbugs.gnu.org > Date: Sun, 17 Jul 2022 13:20:12 +0300 > From: Eli Zaretskii > > > From: Stephen Leake > > Date: Sun, 17 Jul 2022 02:42:04 -0700 > > > > On emacs-devel, Eli said: > > > > AFAICT, this loop in deactivate_process: > > > > /* Beware SIGCHLD hereabouts. */ > > > > for (i = 0; i < PROCESS_OPEN_FDS; i++) > > close_process_fd (&p->open_fd[i]); > > > > doesn't close the last of the 4 descriptors opened by the 2 emacs_pipe > > calls in make-pipe-process. It calls 'close' with the right value, > > and close returns zero, but the pipe stays open. In Emacs 28, this > > same loop successfully closes the descriptor. I don't know why. > > > > Perhaps bisecting could help. > > I think commit a81669c could be the culprit. I hope I fixed this now on master.