From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Mon, 01 Aug 2022 19:34:44 +0300 Message-ID: <831qtz3ot7.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36945"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 56682@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 01 18:46:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIYYn-0009PW-87 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Aug 2022 18:46:29 +0200 Original-Received: from localhost ([::1]:40942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIYYm-0000BX-3P for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Aug 2022 12:46:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIYOg-0001fr-7s for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 12:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIYOf-0007pe-UH for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 12:36:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oIYOf-0005Hp-PE for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 12:36:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Aug 2022 16:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.165937170320234 (code B ref 56682); Mon, 01 Aug 2022 16:36:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 1 Aug 2022 16:35:03 +0000 Original-Received: from localhost ([127.0.0.1]:41473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIYNj-0005GI-Bp for submit@debbugs.gnu.org; Mon, 01 Aug 2022 12:35:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIYNi-0005Fg-1Y for 56682@debbugs.gnu.org; Mon, 01 Aug 2022 12:35:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIYNc-0007PX-HA; Mon, 01 Aug 2022 12:34:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=Subject:To:From:Date:mime-version:in-reply-to: references; bh=DKXdYn6QFKQ7kNmv/2ZL/QCk6B5vmJmUQaiC01YudAg=; b=K8ZWEavTXONL7U f3N3zAhMdNIe40e1tWh0khAp7sN+3AA8LYnAsZegPl1CJc2GEdmvhn7rCNxtdB14lKnEaHJDqcJ8x qqAhnxq/0BnP24OTRkn4arpDEhdwkOJWiXkrJcot2zStyrR6fuIrOhLL/Cpnaeds68AjoF7Ihudkd v+SXmKhKTYMNjz532hsoA2tk1/myDrTdMZ0TOQYV1Jj0j1wmIbPTQor9R3Mym6ZcVqRMz333XidYs uLdcZgtJPiOC8BWgAh3l7svQzfBq4ed54bXqwk6QWRP2zfBHwjYhUnsYgTHsJ3NvVDQyGwU/VzTmu 8IQmj1LEZ7qxzr1TM8YA==; Original-Received: from [87.69.77.57] (port=2943 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIYNb-0005Eh-Ud; Mon, 01 Aug 2022 12:34:56 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238448 Archived-At: This hunk: > @@ -8894,7 +8891,7 @@ get_visually_first_element (struct it *it) > find_newline_no_quit (IT_CHARPOS (*it), > IT_BYTEPOS (*it), -1, > &it->bidi_it.bytepos), > - it->narrowed_begv); > + get_closer_narrowed_begv (it->w, IT_CHARPOS (*it))); > bidi_paragraph_init (it->paragraph_embedding, &it->bidi_it, true); > do > { isn't quite right, I think. Can you explain which, if any, problems you saw or had in mind, and what and how did you want to fix them with this particular hunk? I'd then suggest a better change (or agree with your change, in case I missed something). Thanks.