From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57556: 28.1; Eshell not finding executables in PATH when tramp-integration loaded Date: Thu, 13 Oct 2022 09:35:55 +0300 Message-ID: <831qrcb584.fsf@gnu.org> References: <87h715j5gy.fsf@gmx.de> <0480c49e-75da-68c4-d255-242ff65323fe@gmail.com> <87czbsjyby.fsf@gmx.de> <877d1vthto.fsf@gmx.de> <871qrrffzj.fsf@gmx.de> <2d1f17a5-554d-1b1f-7bcb-52e3839d9d0c@gmail.com> <87wn9iehl1.fsf@gmx.de> <00448968-481d-9bdd-b0c8-7bc3d04e5d60@gmail.com> <87fsfzh4if.fsf@gmx.de> <67159bc7-b50c-ed93-ae3e-154b240b9eb7@gmail.com> <87o7ukdggp.fsf@gmx.de> <10e3d9b6-1fd5-c35f-625b-6dc02aa7de57@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29157"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, 57556@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 13 08:48:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ois18-0007QX-De for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 08:48:30 +0200 Original-Received: from localhost ([::1]:46830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ois14-0002aD-Vp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 02:48:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36106) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oirp7-0001zN-3B for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 02:36:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oirp5-00047k-CK for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 02:36:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oirp4-00017C-3E for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 02:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 06:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57556 X-GNU-PR-Package: emacs Original-Received: via spool by 57556-submit@debbugs.gnu.org id=B57556.16656429504269 (code B ref 57556); Thu, 13 Oct 2022 06:36:02 +0000 Original-Received: (at 57556) by debbugs.gnu.org; 13 Oct 2022 06:35:50 +0000 Original-Received: from localhost ([127.0.0.1]:59096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiros-00016n-7m for submit@debbugs.gnu.org; Thu, 13 Oct 2022 02:35:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiroq-00016Z-5G for 57556@debbugs.gnu.org; Thu, 13 Oct 2022 02:35:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oirok-000476-KD; Thu, 13 Oct 2022 02:35:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=C3YcxWusjW51/ULEyq5vz+PWfjMtziKZo3X6Cop3ZYQ=; b=hr7ejLqlPg6v hlPOxyw6R0uGwTHW2PX1ykvOtHsEGB0gEbihzhYnu9Lm2YVhrGwM8Xl3hFMZyxjIA1AOZYHDXD27U Zi6orlSgHbH6loFHSn02rxsY1B0LUIVxj8DI1/eS7T/Tq+3/loqGZj6e40EVsk3Ikp4D9LspOSUIp 9dRmCZrXbAyNimLOn9Ki1TjFSHWq8heFSY+S3Qk7YsIitNPCjwWNXZ353ZhlCy6fh6BUAMkxQS94o XLtkBg9Dw8chqQjmcmnK49ASwXbJ2zJCh2rjTy6K6RM1yIZ6IEqanaxyCL834Ed17CS/BStk5Bd1e ntygQ0yexWnekqvYtCdBXg==; Original-Received: from [87.69.77.57] (port=3849 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiroj-00026H-Vo; Thu, 13 Oct 2022 02:35:42 -0400 In-Reply-To: <10e3d9b6-1fd5-c35f-625b-6dc02aa7de57@gmail.com> (message from Jim Porter on Wed, 12 Oct 2022 21:11:47 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245268 Archived-At: > Cc: 57556@debbugs.gnu.org > Date: Wed, 12 Oct 2022 21:11:47 -0700 > From: Jim Porter > > On 10/9/2022 11:01 AM, Michael Albinus wrote: > > Jim Porter writes: > > > >> I attached an updated version of my connection-local.el that tries to > >> pull out the additions you made into some helpers. What do you think? > > > > I gave it a short reading, and in general it looks OK (comments > > below). Do you want to provide a patch for files-x.el with this? > > Thanks for taking a look. I've added a separate patch (0002 in this > series) for adding these functions (with some improvements over the > little test script we worked on) to files-x.el. (Patch 0001 just fixes > an issue in the docs/tests where the :application had an extra quote.) > > If you think it would be easier to track, I could file a new bug and put > patches 0001 and 0002 in there, then come back to this bug once that's > merged. Either way is fine by me. > > The other patches in this series are mostly-unchanged from before, > except for 0006, which now uses the new 'setq-connection-local' macro. > > > This patch shall also extent the "Connection Local Variables" section of > > the Elisp manual. This section is already quite > > long (~150 lines), and speaks almost about static setting of > > connection-local variables. You bring dynamic settings here, maybe a > > subsection would help to structure. And feel free to restructure the > > other, long text if you believe it would help. > > I added all this to the manual (with an example), and divided the > Connection Local Variables section into two subsections: one for how to > initialize profiles and set criteria for them, and another for applying > the variables. I put the 'setq-connection-local' docs in the second > section, since it's closely related to 'with-connection-local-variables'. Thanks. Some general documentation-related comments below. > +@node Connection Local Profiles > +@subsection Connection Local Profiles It is generally a good idea to have a @cindex entry for the main topic of a section/subsection. Usually, the @cindex entry is just the node or section name, with all of its words down-cases. For example, here I'd use @cindex connect local profiles And similarly for the other subsection you added. My other general comment is to never miss an opportunity of adding a cross-reference when you reference a term or a symbol described elsewhere in the documentation. Never assume the reader already knows what all the stuff you reference is about. For example: > +You can set variables in a few different ways. To set a Lisp > +variable, you can use the command @samp{setq @var{name} @var{value}}, > +which works much like its Lisp counterpart. This will benefit from a cross-reference to where 'setq' is described in the ELisp reference manual. Please review the documentation changes for more cross-reference opportunities like this one.