From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53941: Last-minute socks.el improvements for Emacs 29? Date: Tue, 29 Nov 2022 16:36:03 +0200 Message-ID: <831qpln7zg.fsf@gnu.org> References: <87pmntfym7.fsf@example.com> <8735kl1v58.fsf@neverwas.me> <87a6emftzx.fsf@example.com> <87k0do5km1.fsf@neverwas.me> <87pmn5n3tu.fsf@neverwas.me> <87mti99j1f.fsf@neverwas.me> <87wnh7hkgi.fsf@gnu.org> <87pmmz947k.fsf@neverwas.me> <8735ju44sk.fsf@neverwas.me> <87lexikwu5.fsf@neverwas.me> <87mt8baygn.fsf_-_@neverwas.me> <8335a3nguk.fsf@gnu.org> <87fse1kfe8.fsf@neverwas.me> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40827"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, gnuhacker@member.fsf.org, 53941@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 29 15:36:43 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p01j1-000AML-8e for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Nov 2022 15:36:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p01ik-0006C7-TJ; Tue, 29 Nov 2022 09:36:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p01iQ-000671-7L for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 09:36:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p01iM-0000WD-AL for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 09:36:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p01iM-00038S-1m for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 09:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Nov 2022 14:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53941 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53941-submit@debbugs.gnu.org id=B53941.166973254012043 (code B ref 53941); Tue, 29 Nov 2022 14:36:02 +0000 Original-Received: (at 53941) by debbugs.gnu.org; 29 Nov 2022 14:35:40 +0000 Original-Received: from localhost ([127.0.0.1]:54568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p01i0-00038B-Bd for submit@debbugs.gnu.org; Tue, 29 Nov 2022 09:35:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p01hy-000384-7k for 53941@debbugs.gnu.org; Tue, 29 Nov 2022 09:35:39 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p01hs-0000O5-Ao; Tue, 29 Nov 2022 09:35:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fUgPMV1q161m0VpeblH/Po7ymom43IQo2JmHcHpECiA=; b=es4BJOc9AeTG JVRcqZQEA7lt1QonrYPgRWCng+ZBo2cnTNag1HgnJCDchl/+KFaoxFGiGbsnbS8zJ0LBEEbCgn1yx ZORT4sZrLeji+1jBUCPR9EPxItoVgvdeKDqoMXdR4udbngpSjlq15qjHgqgfEaPszWA5e1FdYedpZ NnW1geIqEdXDIG9oA/SagwGj8ltyDZpJFQRW2kZ0TMTE6EZfQk4+UtWMikX2/RI75Njw1TwtEk2zO Crf0uq34ZlzI4huy58EwovZPFN6kUpCe54zZwn2bFnFS5lcNOzoOT6AVYGrZ/za76hbV9oCpg/KHb wWaNFNauSmWlCLc0ovyMvQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p01hr-0006fb-KF; Tue, 29 Nov 2022 09:35:32 -0500 In-Reply-To: <87fse1kfe8.fsf@neverwas.me> (jp@neverwas.me) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249405 Archived-At: > From: "J.P." > Cc: 53941@debbugs.gnu.org, gnuhacker@member.fsf.org, larsi@gnus.org > Date: Tue, 29 Nov 2022 06:24:15 -0800 > > Eli Zaretskii writes: > > > I'm really uncomfortable with installing these changes before the release > > branch is cut. The changes are hardly trivial, some controversial even to > > my eyes, even though I'm no expert on network connections. > > Well, I myself am just about the furthest thing from (an expert), which > certainly doesn't comport well with dropping rash changes at the > eleventh hour. (That was rather disrespectful on my part, so shame on > me.) As such, if it's easier to revisit this once things settle down, > just ignore this email and I'll re-ping you sometime down the road. Yes, please do. The branch is cut now, so if we agree on installing such changes on master, it's now up to you when to post another version of these changes with the requisite fixes. > >> +(defun socks-open-network-stream (name buffer host service &rest params) > >> + "Open and return a connection, possibly proxied over SOCKS. > > > > The changes in this public function are so significant that I don't > > understand how they can be suggested so close to the branching. > > The old signature was > > (name buffer host service) -> process I didn't mean the signature (which is OK), I meant the body. It is very different from the previous version. > > If it is possible to add support for SOCKS 4a without affecting any > > previously supported versions, I'm fine. Adding tests is also fine. > > But for the rest, I think you should wait until after the release > > branch is cut and install this on the master branch. Sorry, it really > > is too late for such changes. > > You're very gracious, but I think I've learned my lesson and will > refrain from pursuing any of these changes for Emacs 29. Apologies for > abusing your time and maintainerly patience (yet again). No need to apologize, this is software development. Thanks for working on these issues.