From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 59935@debbugs.gnu.org, juri@linkov.net
Subject: bug#59935: 29.0.60; project-list-buffers is slow
Date: Sat, 10 Dec 2022 22:11:13 +0200 [thread overview]
Message-ID: <831qp7vx26.fsf@gnu.org> (raw)
In-Reply-To: <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> (message from Dmitry Gutov on Sat, 10 Dec 2022 21:53:28 +0200)
> Date: Sat, 10 Dec 2022 21:53:28 +0200
> Cc: 59935@debbugs.gnu.org, juri@linkov.net
> From: Dmitry Gutov <dgutov@yandex.ru>
>
> On 10/12/2022 21:42, Eli Zaretskii wrote:
> >> Date: Sat, 10 Dec 2022 21:19:30 +0200
> >> Cc:59935@debbugs.gnu.org,juri@linkov.net
> >> From: Dmitry Gutov<dgutov@yandex.ru>
> >>
> >> On 10/12/2022 16:33, Eli Zaretskii wrote:
> >>> OK, but I didn't suggest making any changes to revert-buffer-function
> >>> set up by "C-x p C-b". You can still use process-buffers there, and
> >>> it shouldn't slow down "C-x p C-b" itself, since the call to
> >>> process-buffers that is part of revert-buffer-function is not supposed
> >>> to be evaluated when you set revert-buffer-function. Right? Or what
> >>> else am I missing?
> >> Then only the 'g' binding will remain slow. An improvement, of course.
> > Why slow? it calls project-buffers only once.
>
> You're looking at the "legacy" code path. Where emacs-version is < 29.
I'm looking at the code you posted as the original one, which is
identical to what I see on the current emacs-29 branch. That means
Emacs 29, unless I'm seriously confused.
> In the "new" one revert-buffer-function uses the filter-predicate
> argument we pass to list-buffers-noselect. Which is
>
> (lambda (buf) (memq buf (project-buffers pr)))
I see this in emacs-29:
(setq-local revert-buffer-function
(lambda (&rest _ignored)
(list-buffers--refresh (project-buffers pr))
(tabulated-list-print t))))
So I still don't understand your fears.
next prev parent reply other threads:[~2022-12-10 20:11 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 1:49 bug#59935: 29.0.60; project-list-buffers is slow Dmitry Gutov
2022-12-10 2:03 ` Dmitry Gutov
2022-12-10 8:11 ` Eli Zaretskii
2022-12-10 10:47 ` Dmitry Gutov
2022-12-10 11:12 ` Eli Zaretskii
2022-12-10 11:37 ` Dmitry Gutov
2022-12-10 14:33 ` Eli Zaretskii
2022-12-10 19:19 ` Dmitry Gutov
2022-12-10 19:42 ` Eli Zaretskii
2022-12-10 19:53 ` Dmitry Gutov
2022-12-10 20:11 ` Eli Zaretskii [this message]
2022-12-10 20:23 ` Dmitry Gutov
2022-12-11 6:19 ` Eli Zaretskii
2022-12-11 10:23 ` Dmitry Gutov
2022-12-11 10:54 ` Eli Zaretskii
2022-12-11 16:32 ` Dmitry Gutov
2022-12-12 10:36 ` Jean Louis
2022-12-12 17:12 ` Juri Linkov
2022-12-13 3:10 ` Jean Louis
2022-12-12 19:58 ` Dmitry Gutov
2022-12-13 3:10 ` Jean Louis
2022-12-13 15:29 ` Dmitry Gutov
2022-12-13 19:30 ` Jean Louis
2022-12-13 20:31 ` Dmitry Gutov
2022-12-15 14:58 ` Jean Louis
2022-12-15 15:12 ` Dmitry Gutov
2022-12-10 17:45 ` Juri Linkov
2022-12-10 19:22 ` Dmitry Gutov
2022-12-11 17:07 ` Juri Linkov
2022-12-11 17:49 ` Eli Zaretskii
2022-12-11 17:56 ` Juri Linkov
2022-12-11 18:08 ` Eli Zaretskii
2022-12-11 18:13 ` Dmitry Gutov
2022-12-11 18:12 ` Dmitry Gutov
2022-12-11 18:17 ` Eli Zaretskii
2022-12-11 18:35 ` Dmitry Gutov
2022-12-11 19:00 ` Eli Zaretskii
2022-12-11 19:41 ` Dmitry Gutov
2022-12-11 20:42 ` Eli Zaretskii
2022-12-12 17:16 ` Juri Linkov
2022-12-12 17:27 ` Eli Zaretskii
2022-12-12 17:51 ` Juri Linkov
2022-12-12 18:10 ` Eli Zaretskii
2022-12-12 18:14 ` Juri Linkov
2022-12-12 18:22 ` Eli Zaretskii
2022-12-13 17:49 ` Juri Linkov
2022-12-11 18:37 ` Dmitry Gutov
2022-12-13 17:49 ` Juri Linkov
2022-12-13 18:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qp7vx26.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59935@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).