From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' Date: Thu, 02 Mar 2023 15:56:11 +0200 Message-ID: <831qm7dzpg.fsf@gnu.org> References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18192"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61816@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 02 14:57:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXjR8-0004W4-GH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Mar 2023 14:57:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXjQd-00046K-Tu; Thu, 02 Mar 2023 08:57:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXjQc-00045u-RH for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 08:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXjQc-000326-Gu for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 08:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXjQb-0005CL-SW for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 08:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Mar 2023 13:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61816-submit@debbugs.gnu.org id=B61816.167776538819928 (code B ref 61816); Thu, 02 Mar 2023 13:57:01 +0000 Original-Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 13:56:28 +0000 Original-Received: from localhost ([127.0.0.1]:56202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXjQ3-0005BL-HX for submit@debbugs.gnu.org; Thu, 02 Mar 2023 08:56:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXjQ0-0005B6-Uj for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 08:56:25 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXjPv-0002cn-4T; Thu, 02 Mar 2023 08:56:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/7aIqH0Hb24G8r+W4Py7D5yM7DeNB4gLXHPAfaByvG8=; b=Zy8VMJKuj+7e F6pFgoOsFQAhLPpIjIl0qRIidDH3dMdRwbthH7PnkVqE283HQW0VZ6jmsVuNoJdO9cKXke8ZT45rQ wCOvZfY1myKKzY28iIVVDfZmift1b2vN+WQ0NjTLXgvuabVQwRnkH0z4ATfvhpEvVYdgbxG9WinFb 64pa4+K0qqzQBTws39oze0pQCut4CEo9eP2ZZndjyw1Gg3cJgJSG9eO+pXd+CqcTRTDaOTmQVrWyd AEbUuDB2V0Tm0i5opxFxOQbLOrJIEB3eqM4fzDwYOVh5Q98tJC8TDYLc1u9/xkdfZULrFAMkkTQJf kSdS8XSk25GmSv8hd6xfbw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXjPu-0003hc-KB; Thu, 02 Mar 2023 08:56:18 -0500 In-Reply-To: <87ttz3jnzo.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 02 Mar 2023 14:12:43 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257158 Archived-At: > From: Manuel Giraud > Cc: 61816@debbugs.gnu.org > Date: Thu, 02 Mar 2023 14:12:43 +0100 > > Eli Zaretskii writes: > > >> Date: Sun, 26 Feb 2023 16:33:02 +0100 > >> From: Manuel Giraud via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> Here is a new user option to make DocView, with SVG backend, honor the > >> current theme colors. > > > > I have nothing against the feature, but wouldn't it be better to > > modify DocView to use faces for this, and then themes could override > > those faces? > > Why not but I have two issues with this: > > - we had to set those new faces in every Emacs' themes and also wait > for any theme maker to use them > > - those are really just two colors not real faces as the rendering > is controlled by an external tool anyway You are right, of course. It just feels strange to need to cater to themes in a core package, when the way themes are supposed to customize Emacs exists and can be used in this case as well. Alternatively, maybe themes should have settings for features such as this one?