From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62009: 29.0.60; Emacs crashes on setf symbol-name Date: Sat, 11 Mar 2023 17:37:16 +0200 Message-ID: <831qlvwb83.fsf@gnu.org> References: <87o7p5of4n.fsf@daniel-mendler.de> <871qm01s6n.fsf@web.de> <9fcf05e8-506c-6566-e214-2ecf3194b85e@daniel-mendler.de> <83bkl45ul4.fsf@gnu.org> <87v8j9zl3i.fsf@posteo.net> <83a60l13p2.fsf@gnu.org> <87ilf9571k.fsf@gmail.com> <87edpx56xm.fsf@gmail.com> <83wn3ozuyn.fsf@gnu.org> <83h6uszsvq.fsf@gnu.org> <0bd86aa3966395deee4f@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38100"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, michael_heerdegen@web.de, mail@daniel-mendler.de, rpluim@gmail.com, monnier@iro.umontreal.ca, 62009@debbugs.gnu.org, arstoffel@gmail.com To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 11 16:38:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pb1IO-0009kS-CY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Mar 2023 16:38:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pb1IL-0003iT-42; Sat, 11 Mar 2023 10:38:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pb1IJ-0003iJ-5V for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 10:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pb1II-0003bu-QZ for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 10:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pb1II-000096-IW for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 10:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Mar 2023 15:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62009 X-GNU-PR-Package: emacs Original-Received: via spool by 62009-submit@debbugs.gnu.org id=B62009.1678549062534 (code B ref 62009); Sat, 11 Mar 2023 15:38:02 +0000 Original-Received: (at 62009) by debbugs.gnu.org; 11 Mar 2023 15:37:42 +0000 Original-Received: from localhost ([127.0.0.1]:58500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pb1Hy-00008X-2F for submit@debbugs.gnu.org; Sat, 11 Mar 2023 10:37:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pb1Hw-00008K-Cu for 62009@debbugs.gnu.org; Sat, 11 Mar 2023 10:37:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pb1Hn-0003ZD-O6; Sat, 11 Mar 2023 10:37:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aT3SVwsJdQ74OVGomGhKKdwx+B90AUcHpWtTfPCgAnY=; b=lKTVPKD86Nm8 jhfwE0B3EQd0EwtQ2jBx58sE2yx543DSfY+ZWe7zYLpGP/PODUAwFDQURR5Uu9lZm+C6j9jLi5PjQ B6lHNChPKkQNA2O/Ijn6YrhMc164C93I50lz17+E97vinkcIyC3rtuciaB0ACWby6mJai4LfsUFEx 7GGHRP1UgyTF8ftrSCHCRNAY3Q7ovmYcKuVryA/NciniNtVO9/XoT2mZTMIme+sZmrq+EldTrQNnx WU0GFmMeVjM8IcOKJYsc6P/2OLmj6TMt6gia4Xhj0A+E2GVYOHvnNYSWoNRrRasFCfTup37KZ4jM2 1Qrxybzy2qvKcNyZsq7ovg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pb1Hn-0006NZ-6w; Sat, 11 Mar 2023 10:37:31 -0500 In-Reply-To: <0bd86aa3966395deee4f@heytings.org> (message from Gregory Heytings on Sat, 11 Mar 2023 15:16:36 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257806 Archived-At: > Date: Sat, 11 Mar 2023 15:16:36 +0000 > From: Gregory Heytings > cc: Daniel Mendler , philipk@posteo.net, > michael_heerdegen@web.de, rpluim@gmail.com, monnier@iro.umontreal.ca, > 62009@debbugs.gnu.org, arstoffel@gmail.com > > > > > > Sorry, I object to any change to cater for this use case. > > > > IMO a reasonable change here would be to update the docstring of > symbol-name, which only says "Return SYMBOL's name, a string.", with a > warning similar to the one in the manual: > > Warning: Changing the string by substituting characters does change the > name of the symbol, but fails to update the obarray, so don't do it! That is okay, of course. My objection was to the code changes. > Perhaps we could also explicitly mention, in the docstring and/or in the > manual, that doing that can also crash Emacs. I think being a bit vague here and talking about "dangers" should be good enough, since not every such code will crash, and probably also not on every platform and in every build configuration.