From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion behave unintuitively when point is not at end of buffer Date: Sun, 09 Apr 2023 20:38:27 +0300 Message-ID: <831qktlzvw.fsf@gnu.org> References: <864jpsrgaz.fsf@mail.linkov.net> <86h6tr4pi8.fsf@mail.linkov.net> <87sfdbmmmh.fsf@catern.com> <838rf2opa0.fsf@gnu.org> <86ttxqdwyp.fsf@mail.linkov.net> <83cz4emap9.fsf@gnu.org> <863559xb3u.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10397"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62700@debbugs.gnu.org, sbaugh@catern.com, sbaugh@janestreet.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 09 19:38:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plYzQ-0002WI-Jz for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Apr 2023 19:38:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plYzN-0003li-2l; Sun, 09 Apr 2023 13:38:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plYzK-0003lV-LZ for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 13:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plYzK-00021W-DN for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 13:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plYzK-0001iK-8l for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 13:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Apr 2023 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62700 X-GNU-PR-Package: emacs Original-Received: via spool by 62700-submit@debbugs.gnu.org id=B62700.16810618776573 (code B ref 62700); Sun, 09 Apr 2023 17:38:02 +0000 Original-Received: (at 62700) by debbugs.gnu.org; 9 Apr 2023 17:37:57 +0000 Original-Received: from localhost ([127.0.0.1]:33601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plYzE-0001hw-Rk for submit@debbugs.gnu.org; Sun, 09 Apr 2023 13:37:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plYzD-0001hj-NS for 62700@debbugs.gnu.org; Sun, 09 Apr 2023 13:37:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plYz7-00020N-SJ; Sun, 09 Apr 2023 13:37:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ruY0n+MbkIdvQURpChgtqUiobaz/pY78TzMFL8NDge8=; b=mqoXB0w9/EbT UpDRq87sO5F/pacVcGT4IwugFfaiRO7GaecuOvXYJMhQhdOT6IL1q58wtnowKE3nKCS5kor1tsyjE Q1Pm+AInCgbzsn8GXtXU6CMzzhXMJuirCpqt+HtI6bwZdeh9R0H4YdaMJPFfftFbZ1gg87mYg+yC/ Dr0qudcwre92o+hQMWm6Q8gT0P/gsoFEZG9JTRLZhyvE+PAdhBsAdJWFMoqSXIcz3bFszxAJl4NId 8xQzvw7am5esvxsNFTE/cJMxzi1wfcaf2RSr6VdmHsSHdxJcDJVdqozdMf5/C9k1AwdqNt6f+DE3M 8zti/W6J9xWDg8/tDskh6g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plYz7-0002CZ-4o; Sun, 09 Apr 2023 13:37:49 -0400 In-Reply-To: <863559xb3u.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 09 Apr 2023 19:40:37 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259531 Archived-At: > From: Juri Linkov > Cc: sbaugh@catern.com, 62700@debbugs.gnu.org, sbaugh@janestreet.com > Date: Sun, 09 Apr 2023 19:40:37 +0300 > > >> > If this is for master, I'm fine with such changes. But if you intend > >> > to request installing this on emacs-29, then I will object making > >> > non-trivial changes in any code that is not specific to the M- and > >> > >> Actually, a change for base-suffix in minibuffer-completion-help > >> is a trivial change. What counts as a non-trivial change would be > >> changing the API in completion-all-completions. > >> > >> > M- bindings that are new in Emacs 29. I don't want to risk any > >> > regressions in general-purpose completion code at this late stage. > >> > >> These changes are specific to the M- and M- bindings: > >> completion-use-base-affixes is nil, and it's let-bound to t > >> in M- (minibuffer-previous-completion) and M- > >> (minibuffer-next-completion). > > > > The change I reviewed and to which I responded was in code that was > > there in Emacs 28 as well. Maybe we are talking about two different > > sets of changes. > > That code was added in Emacs 29 a year ago in the commit > 7aaffe25eb178f69027fb0af844a89a86db4b1f2. Ah, you mean that part. Yes, but a year is a long time, and making non-trivial changes there now is not something I'd like to do.