From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 62700@debbugs.gnu.org, sbaugh@catern.com, sbaugh@janestreet.com
Subject: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion behave unintuitively when point is not at end of buffer
Date: Sun, 09 Apr 2023 20:38:27 +0300 [thread overview]
Message-ID: <831qktlzvw.fsf@gnu.org> (raw)
In-Reply-To: <863559xb3u.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 09 Apr 2023 19:40:37 +0300)
> From: Juri Linkov <juri@linkov.net>
> Cc: sbaugh@catern.com, 62700@debbugs.gnu.org, sbaugh@janestreet.com
> Date: Sun, 09 Apr 2023 19:40:37 +0300
>
> >> > If this is for master, I'm fine with such changes. But if you intend
> >> > to request installing this on emacs-29, then I will object making
> >> > non-trivial changes in any code that is not specific to the M-<UP> and
> >>
> >> Actually, a change for base-suffix in minibuffer-completion-help
> >> is a trivial change. What counts as a non-trivial change would be
> >> changing the API in completion-all-completions.
> >>
> >> > M-<DOWN> bindings that are new in Emacs 29. I don't want to risk any
> >> > regressions in general-purpose completion code at this late stage.
> >>
> >> These changes are specific to the M-<UP> and M-<DOWN> bindings:
> >> completion-use-base-affixes is nil, and it's let-bound to t
> >> in M-<UP> (minibuffer-previous-completion) and M-<DOWN>
> >> (minibuffer-next-completion).
> >
> > The change I reviewed and to which I responded was in code that was
> > there in Emacs 28 as well. Maybe we are talking about two different
> > sets of changes.
>
> That code was added in Emacs 29 a year ago in the commit
> 7aaffe25eb178f69027fb0af844a89a86db4b1f2.
Ah, you mean that part. Yes, but a year is a long time, and making
non-trivial changes there now is not something I'd like to do.
next prev parent reply other threads:[~2023-04-09 17:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 17:56 bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion behave unintuitively when point is not at end of buffer Spencer Baugh
2023-04-06 18:22 ` Eli Zaretskii
2023-04-06 18:58 ` Spencer Baugh
2023-04-06 19:30 ` Eli Zaretskii
2023-04-06 20:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-06 18:55 ` Juri Linkov
2023-04-06 19:22 ` Spencer Baugh
2023-04-07 16:37 ` Juri Linkov
2023-04-07 21:02 ` sbaugh
2023-04-08 6:34 ` Eli Zaretskii
2023-04-08 10:58 ` sbaugh
2023-04-08 13:19 ` Eli Zaretskii
2023-04-08 18:36 ` Juri Linkov
2023-04-08 19:32 ` Eli Zaretskii
2023-04-09 16:40 ` Juri Linkov
2023-04-09 17:38 ` Eli Zaretskii [this message]
2023-04-08 18:30 ` Juri Linkov
[not found] ` <ierbk6lup79.fsf@janestreet.com>
2024-04-07 17:16 ` Juri Linkov
[not found] <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@email.android.com>
2023-04-10 18:20 ` Juri Linkov
2023-04-20 16:52 ` Spencer Baugh
2023-04-20 18:18 ` Juri Linkov
2023-04-20 18:46 ` Spencer Baugh
2023-04-20 19:00 ` Eli Zaretskii
2023-04-21 18:56 ` sbaugh
2023-04-22 10:48 ` Eli Zaretskii
2023-04-22 12:57 ` sbaugh
2023-04-22 13:15 ` Eli Zaretskii
2023-04-22 21:38 ` sbaugh
2023-04-23 6:13 ` Eli Zaretskii
2023-04-23 11:48 ` sbaugh
2023-04-24 11:22 ` Eli Zaretskii
2023-05-02 15:13 ` sbaugh
2023-05-02 17:57 ` Eli Zaretskii
2023-05-08 15:48 ` Juri Linkov
2023-05-08 16:11 ` Eli Zaretskii
2023-06-03 0:58 ` Spencer Baugh
2023-06-04 7:09 ` Eli Zaretskii
2023-06-10 10:51 ` Eli Zaretskii
2023-06-12 18:27 ` Juri Linkov
2023-06-13 2:32 ` Eli Zaretskii
2023-06-13 16:54 ` Juri Linkov
2023-06-13 16:59 ` Eli Zaretskii
2023-06-13 20:59 ` Spencer Baugh
2023-06-14 17:32 ` Juri Linkov
2023-09-03 17:37 ` Juri Linkov
2023-09-04 0:30 ` sbaugh
2023-09-04 6:51 ` Juri Linkov
2023-11-14 7:39 ` Juri Linkov
2023-11-15 17:42 ` Juri Linkov
2023-04-20 18:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qktlzvw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62700@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=sbaugh@catern.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).