From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63655: 29.0.91; Dialog box not displayed upon closing frame Date: Tue, 23 May 2023 16:00:17 +0300 Message-ID: <831qj7p5i6.fsf@gnu.org> References: <87lehfwrzt.fsf.ref@yahoo.com> <87lehfwrzt.fsf@yahoo.com> <83fs7npadp.fsf@gnu.org> <87h6s3w8rl.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18280"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63655@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 23 15:00:51 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1RdD-0004ZQ-6L for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 May 2023 15:00:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1RcX-0001M3-C2; Tue, 23 May 2023 09:00:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1RcS-0001KT-3D for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 09:00:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1RcR-0007kr-NU for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 09:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q1RcQ-0006Hf-NW for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 09:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 May 2023 13:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63655 X-GNU-PR-Package: emacs Original-Received: via spool by 63655-submit@debbugs.gnu.org id=B63655.168484679924121 (code B ref 63655); Tue, 23 May 2023 13:00:02 +0000 Original-Received: (at 63655) by debbugs.gnu.org; 23 May 2023 12:59:59 +0000 Original-Received: from localhost ([127.0.0.1]:38585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1RcN-0006Gz-DH for submit@debbugs.gnu.org; Tue, 23 May 2023 08:59:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1RcL-0006Gg-RA for 63655@debbugs.gnu.org; Tue, 23 May 2023 08:59:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1RcG-0007jO-JI; Tue, 23 May 2023 08:59:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7CH0Z4wJbSeC7ok0W3zyDXeXg0NSiJ5BU19EllwmiyM=; b=sRA328r2iROG gTigt+7KlxZq6VsPNj92JePjFuJxNQAY05qUhbjbyZUe00QTAh7yW/FNvBYFmRPl2UjCc9jLPOGQL X94dhsJdB4wP5ZWzAfzwDkj1Gf0SKIcP7sC4G3qTDvpTEwdNW6iPrMvIjquYFlZTyNtmHnTqL+03X b9sgDoMzE+Qo/wYdrg9gldZKyyL5PJbGX8yURJsZ4Pbpsfn3w10QJLEYnvE1tBQnlo4Py6c/qN007 Ays6KAKHbSWDQws8CDcjA6O8NHjWfuhKBVReynr2ojF+j9UT0PLt6yY1u4/MY8SnAT1hKKzNcxhNX f9v+DrlH3K9DV4bHlqGoeQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1RcG-00043u-1Y; Tue, 23 May 2023 08:59:52 -0400 In-Reply-To: <87h6s3w8rl.fsf@yahoo.com> (message from Po Lu on Tue, 23 May 2023 20:07:58 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262220 Archived-At: > From: Po Lu > Cc: 63655@debbugs.gnu.org > Date: Tue, 23 May 2023 20:07:58 +0800 > > Eli Zaretskii writes: > > >> Really exit Emacs? (y or n) > > > > confirm-kill-emacs, if non-nil, should be a function. If I try what > > you described above, Emacs signals an error when I close the last > > frame. > > Sorry, I meant to set it to `y-or-n-p'. I did that from Custom. Does the patch below give good results? diff --git a/lisp/subr.el b/lisp/subr.el index 52227b5..9aa28d9 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -3544,6 +3544,8 @@ use-dialog-box-p "Return non-nil if the current command should prompt the user via a dialog box." (and last-input-event ; not during startup (or (consp last-nonmenu-event) ; invoked by a mouse event + (and (null last-nonmenu-event) + (consp last-input-event)) from--tty-menu-p) ; invoked via TTY menu use-dialog-box)) diff --git a/src/fns.c b/src/fns.c index e8cd621..e01739c 100644 --- a/src/fns.c +++ b/src/fns.c @@ -3193,8 +3193,11 @@ DEFUN ("yes-or-no-p", Fyes_or_no_p, Syes_or_no_p, 1, 1, 0, CHECK_STRING (prompt); - if ((NILP (last_nonmenu_event) || CONSP (last_nonmenu_event)) - && use_dialog_box && ! NILP (last_input_event)) + if (!NILP (last_input_event) + && (CONSP (last_nonmenu_event) + || (NILP (last_nonmenu_event) && CONSP (last_input_event)) + || !NILP (find_symbol_value (Qfrom__tty_menu_p))) + && use_dialog_box) { Lisp_Object pane, menu, obj; redisplay_preserve_echo_area (4); @@ -6358,4 +6361,5 @@ syms_of_fns (void) defsubr (&Sbuffer_line_statistics); DEFSYM (Qreal_this_command, "real-this-command"); + DEFSYM (Qfrom__tty_menu_p, "from--tty-menu-p"); }