From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63754: 29.0.91; tmm breaks when tmm-completion-prompt is nil Date: Sat, 27 May 2023 20:15:12 +0300 Message-ID: <831qj1k867.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5934"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63754@debbugs.gnu.org To: Thiago Melo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 27 19:15:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2xVg-0001JT-0Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 May 2023 19:15:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2xVR-0004AQ-1K; Sat, 27 May 2023 13:15:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2xVP-0004AD-AA for bug-gnu-emacs@gnu.org; Sat, 27 May 2023 13:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2xVO-0005cN-J1 for bug-gnu-emacs@gnu.org; Sat, 27 May 2023 13:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2xVO-00037r-4E for bug-gnu-emacs@gnu.org; Sat, 27 May 2023 13:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 May 2023 17:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63754 X-GNU-PR-Package: emacs Original-Received: via spool by 63754-submit@debbugs.gnu.org id=B63754.168520768711967 (code B ref 63754); Sat, 27 May 2023 17:15:02 +0000 Original-Received: (at 63754) by debbugs.gnu.org; 27 May 2023 17:14:47 +0000 Original-Received: from localhost ([127.0.0.1]:52489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2xV8-00036w-Ru for submit@debbugs.gnu.org; Sat, 27 May 2023 13:14:47 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2xV6-00036b-Ph for 63754@debbugs.gnu.org; Sat, 27 May 2023 13:14:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2xV0-0005Za-5A; Sat, 27 May 2023 13:14:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FCD1NtOYOCc9av8YxOPWM6dYYpRhGRGczF8aCBF7XvY=; b=byXzvvpuBSjX ogaQg//q1WjszVT6bsH4WNt8+cSle9KwPx3SI2NWroz/uaRfJ83QWnyzCq7trHhHk1QpwEfz3bLDR a2JzzeDtVISEQ4pN7mtnXlSM1bX9572jDnv7dg304tBzq3zpSm8c8GkEjCRcL8+WXQV42hIPMptdN AGRC4t6mkmCL8L78ff9V/RV2ruhxHzxP9+B3KVHlUmoIha7uPDg5TBmSlEKVwa5Pkwec8Qnjdozp5 M0z7buZ6117whJu6nHWkBrOpAvf5JFlV8TiELXM4ywL3/1Wb+fDYimc9ZpUKfUI4aF8UjhtB4o2c4 Cv/tdvqcltSbbrCpMqjTwg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2xUz-0006Cg-8D; Sat, 27 May 2023 13:14:37 -0400 In-Reply-To: (message from Thiago Melo on Sat, 27 May 2023 14:53:59 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262481 Archived-At: > From: Thiago Melo > Date: Sat, 27 May 2023 14:53:59 +0000 > > Issue doesn't happen with Emacs 28. > > * How to reproduce > > run: > emacs -Q > > eval: > (setq tmm-completion-prompt nil) > (tmm-menubar) ; or `tmm-prompt' with any menu/keymap > > * Backtrace > > Debugger entered--Lisp error: (search-failed "Possible completions are:\n") > search-forward("Possible completions are:\n") > tmm-completion-delete-prompt() > run-hooks(completion-setup-hook) > display-completion-list((#("f==>File" 0 1 (face Thanks. This was caused by a change in the completion heading line in Emacs 29: it is now a customizable format string, and can be nil. So the method used by tmm.el for finding the prompt (so it could delete it) is no longer workable, and must be replaced by a different method. Should be fixed now on the emacs-29 branch. (I also fixed it to work when 'tmm-mid-prompt' is nil, something that seems to have been broken since about forever -- I found that bug while testing the patch, because the patch has to work also when 'tmm-mid-prompt' is nil, and there are no menu shortcuts shown.)