From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Date: Tue, 27 Jun 2023 18:52:24 +0300 Message-ID: <831qhwx5qf.fsf@gnu.org> References: <87pm5h4iy1.fsf@t510.orion.oneofus.la> <83h6qtw3tq.fsf@gnu.org> <87wmzp2e0d.fsf@t510.orion.oneofus.la> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14909"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64311@debbugs.gnu.org To: Vladimir Sedach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 27 17:53:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEB0K-0003eD-Uh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Jun 2023 17:53:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEB03-0001LS-Rq; Tue, 27 Jun 2023 11:53:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEB02-0001K5-IL for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 11:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEB02-0000YO-9Z for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 11:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qEB01-00048M-RT for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 11:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2023 15:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64311-submit@debbugs.gnu.org id=B64311.168788112915818 (code B ref 64311); Tue, 27 Jun 2023 15:53:01 +0000 Original-Received: (at 64311) by debbugs.gnu.org; 27 Jun 2023 15:52:09 +0000 Original-Received: from localhost ([127.0.0.1]:49401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEAzA-000474-Ob for submit@debbugs.gnu.org; Tue, 27 Jun 2023 11:52:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEAz9-00046o-6d for 64311@debbugs.gnu.org; Tue, 27 Jun 2023 11:52:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEAz3-0000NU-Jz; Tue, 27 Jun 2023 11:52:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kUjku3Z+H3hGV0HYa2DGdkb35h0l9zXp0bu3eqwCrTk=; b=ANzIjxWrUchP 3TN7cx83pPffD6e15TenRzgznSJlK288tav1at8hN/JMF2YRFlA0pUF5VNaP3Gpwn/csCUBbLTVKC CTScn1EcgV1UZyRkWyVTC899PFxpdxTpXkMI0xrXGRqR6cUayM9Va8v5aDxihMf3WHvc6fphSmlao 1mfT6+T7TEVlXL7l6k9WfdsXYLkVYYUnkCP/NuL+GsansD7w2Bu8bLHpfrWEvM19S37hCl4lVZe/h 2GQ4Q6yQsQbPKH4ulAK/MNILFr50YOrB9Xmmm/eobILIPRXytWtmBuypsY3LtVJRHdACATPC6caha oEYprkL7gJsjmr4kROsbSg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEAz3-0005oo-49; Tue, 27 Jun 2023 11:52:01 -0400 In-Reply-To: <87wmzp2e0d.fsf@t510.orion.oneofus.la> (message from Vladimir Sedach on Tue, 27 Jun 2023 08:09:22 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264166 Archived-At: > From: Vladimir Sedach > Cc: 64311@debbugs.gnu.org > Date: Tue, 27 Jun 2023 08:09:22 -0600 > > This changed in commit 3c059f269e0182bd19df37871585e0b0bf1d47e5 > Redo `C-h m' output > Wed Apr 13 03:50:06 2022 +0200 > > This only hides the problem, which is: the default value of > shell-dirtrack-mode being t. Why is that a problem. I understand when it causes irrelevant minor mode to be shown by "C-h m", but why should anyone care that some global variable is non-nil? In any case, I don't think a fix (if we need one) should be so complicated. Why do we need all those changes, including making the variable obsolete and moving the mode from its place in shell.el to another place there? If all you want is to make this variable buffer-local, just making it buffer-local is all that's needed, right? But first, let's talk about the problem: why is shell-dirtrack-mode being t a problem?