From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64395: [PATCH] * src/xdisp.c (display_string): Don't truncate mode line in terminal Date: Sat, 15 Jul 2023 10:47:58 +0300 Message-ID: <831qh9ehu9.fsf@gnu.org> References: <20230701062756.78266-1-gongqijian@gmail.com> <83zg4gqdef.fsf@gnu.org> <834jmnrjzv.fsf@gnu.org> <831qhrrjlb.fsf@gnu.org> <83zg4fq48r.fsf@gnu.org> <83wmzjq1sf.fsf@gnu.org> <83ttunpzmc.fsf@gnu.org> <83y1jyohk7.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13806"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64395-done@debbugs.gnu.org To: gongqijian@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 09:48:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKa0d-0003JQ-K7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 09:48:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKa0b-000603-8g; Sat, 15 Jul 2023 03:48:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKa0Z-0005zJ-2j for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 03:48:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKa0Y-0006tV-RB for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 03:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKa0Y-0001UG-Nf for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 03:48:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 07:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 64395 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 64395@debbugs.gnu.org, eliz@gnu.org, gongqijian@gmail.com Original-Received: via spool by 64395-done@debbugs.gnu.org id=D64395.16894072655598 (code D ref 64395); Sat, 15 Jul 2023 07:48:02 +0000 Original-Received: (at 64395-done) by debbugs.gnu.org; 15 Jul 2023 07:47:45 +0000 Original-Received: from localhost ([127.0.0.1]:44001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKa0G-0001SC-WB for submit@debbugs.gnu.org; Sat, 15 Jul 2023 03:47:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKa0F-0001RW-M8 for 64395-done@debbugs.gnu.org; Sat, 15 Jul 2023 03:47:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKa09-0006lE-FC; Sat, 15 Jul 2023 03:47:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CooiSSjpVhbNCejEmk5VJaLPANWK7AhPcT7ddolf9tY=; b=Yjdxh8NtBDiw 0alQRKNpBcNKN2lYvcKolppzzeqC4HfPh0DafjgISwEsJgOW92FrVTcYmjPe603XOSZGwr6a+Ma71 1SsWMfQYzAeYG8ZD85koOLVU7cgUKfg1AyIuLWqvB8Kw++7oNnEO5ApTLFF21GI67KIpVtl1HdWuF L0WENpL3neqBnNQr0ucTIZgCiC7uEtOSKW3pEfbKJMHtDBhn49kAdNGeGiYWFgHX8v5kvokk7ydeI yVdWUtR1kfkkKxYzS25SkUrBmrYvBxmRhFVIIWHLBfYuLjj6Toq0/eiESzOXUrSVONhgczglA0Xcx sypS6o36fnhZs/EtcVYp3g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKa08-0002FS-Vf; Sat, 15 Jul 2023 03:47:37 -0400 In-Reply-To: <83y1jyohk7.fsf@gnu.org> (message from Eli Zaretskii on Sun, 02 Jul 2023 11:15:20 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265159 Archived-At: > Cc: 64395@debbugs.gnu.org > Date: Sun, 02 Jul 2023 11:15:20 +0300 > From: Eli Zaretskii > > > Cc: 64395@debbugs.gnu.org > > Date: Sat, 01 Jul 2023 15:47:39 +0300 > > From: Eli Zaretskii > > > > Your proposed change fixes the problem, but it fixes it incorrectly: > > after applying the patch, I see a truncation glyph "$" at the end of > > the mode line. This should never happen on the mode line: we don't > > show truncation glyphs there. Compare the display after applying your > > patch with the mode-line displayed after evaluating the below: > > > > (setq mode-line-format > > (concat (format-mode-line > > "- Ln %l, Col %c ") > > (make-string 100 ?-))) > > > > As you see, the expected display of the mode line that is truncated is > > simply not to see the truncated part, without any "$" truncation > > glyph at the end of the mode line. > > > > So a slightly different change is needed to properly fix this case. > > I'm working on such a proper fix. > > Should be fixed now on the master branch, please test. No further comments within 2 weeks, so I presume the bug has indeed been solved, and I'm therefore closing it.