From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Sun, 16 Jul 2023 14:26:48 +0300 Message-ID: <831qh89jwn.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> <83lefj4okb.fsf@gnu.org> <83fs5r3tqv.fsf@gnu.org> <834jm6fppc.fsf@gnu.org> <87a5vyidy6.fsf@localhost> <83sf9qe2ip.fsf@gnu.org> <83a5vxejz6.fsf@gnu.org> <83r0p9b3om.fsf@gnu.org> <83jzv1b152.fsf@gnu.org> <87lefggmzt.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24305"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, 64596@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 16 13:27:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKzuL-000669-Rd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jul 2023 13:27:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKzu4-0008O4-Oc; Sun, 16 Jul 2023 07:27:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKzu2-0008Ns-Ot for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 07:27:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKzu2-00026U-FG for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 07:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKzu2-0005Et-0o for bug-gnu-emacs@gnu.org; Sun, 16 Jul 2023 07:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jul 2023 11:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168950679520105 (code B ref 64596); Sun, 16 Jul 2023 11:27:01 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 16 Jul 2023 11:26:35 +0000 Original-Received: from localhost ([127.0.0.1]:46960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKztb-0005EC-7d for submit@debbugs.gnu.org; Sun, 16 Jul 2023 07:26:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKztZ-0005E0-7K for 64596@debbugs.gnu.org; Sun, 16 Jul 2023 07:26:34 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKztS-0001rW-0G; Sun, 16 Jul 2023 07:26:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aRgN6D2nWkjHJj23Y0f+LZmsQhVSPlZmz5kHjcucsmc=; b=YD+RJU+J9Uvd EoAKRZ7gzNyVmUDzP3NbPNfKJKgDpmXQFdPwXPr6/MTBtPilOz3vTN/hSnm2IfmUw6GTsnOUJNmTM GsieUGXVivrKwetvDbUFYO0EBvj5nFtgWt5ovXbjkmUBeB6QKDSoJr36c19EWX1mGqXPUSPBN3QIr toM5Mps8jor6mNCd20gYrx7Gg0QWY8/3D/0HCHZfQwkAZB+yCDBkJ4aoEX7fv4NYdeJUwGv19L0fb yuhdrLBDUcuFwGmpKv4oc2QkiruWpdrUKmqrh7CmgEN9mgs76EbKL0NiI3jiqVUb0EnvRft1zPCby yAUbSJmQ5jI86z1VdCVpTQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKztR-0005yk-Fb; Sun, 16 Jul 2023 07:26:25 -0400 In-Reply-To: <87lefggmzt.fsf@localhost> (message from Ihor Radchenko on Sun, 16 Jul 2023 10:38:14 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265317 Archived-At: > From: Ihor Radchenko > Cc: Eli Zaretskii , 64596@debbugs.gnu.org > Date: Sun, 16 Jul 2023 10:38:14 +0000 > > It would be even better if *-mode-lines functions were renamed to > something more explicit. It is very disorienting that "mode-line" may > mean actual mode-line, but sometimes more than that. > A clarifying comment is an improvement, but does not make the code in > other places more readable. If we want to do this, the job is larger yet. We also have this: struct glyph_row { [...] /* True means row is a mode or header/tab-line. */ bool_bf mode_line_p : 1; /* True means row is a tab-line. */ bool_bf tab_line_p : 1; struct it { [...] /* True means window has a tab line at its top. */ bool_bf tab_line_p : 1; /* True means window has a mode line at its top. */ bool_bf header_line_p : 1; struct glyph_matrix { [...] /* True means window displayed in this matrix has a tab line. */ bool_bf tab_line_p : 1; /* True means window displayed in this matrix has a header line. */ bool_bf header_line_p : 1; and the code which deals with these. (Note that the bits are inconsistent between glyph_row and the other two structures, and all of them mention only 2 out of 3 attributes.)