From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64914: [PATCH] * gdb-mi.el: allow disabling the gdb io buffer Date: Fri, 28 Jul 2023 18:48:28 +0300 Message-ID: <831qgsjaur.fsf@gnu.org> References: <83mszgjnf7.fsf@gnu.org> <65da37ba-9f1e-4f42-8a27-2f7b0f60c700@app.fastmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27103"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64914@debbugs.gnu.org To: LemonBreezes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 28 17:58:54 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPPrh-0006pL-Oz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jul 2023 17:58:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPPiD-0004Sy-Gj; Fri, 28 Jul 2023 11:49:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPPiA-0004Qj-Uc for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 11:49:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPPiA-0006Cp-Lv for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 11:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qPPiA-0007KS-81 for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 11:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2023 15:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64914-submit@debbugs.gnu.org id=B64914.169055928327972 (code B ref 64914); Fri, 28 Jul 2023 15:49:02 +0000 Original-Received: (at 64914) by debbugs.gnu.org; 28 Jul 2023 15:48:03 +0000 Original-Received: from localhost ([127.0.0.1]:45898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPPhC-0007H4-Fr for submit@debbugs.gnu.org; Fri, 28 Jul 2023 11:48:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPPhA-0007Fw-53 for 64914@debbugs.gnu.org; Fri, 28 Jul 2023 11:48:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPPh3-00064n-M1; Fri, 28 Jul 2023 11:47:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oJFClKG1EKkbe6wjbypwJrvwuJqitSE4pFt5BW2Z8oY=; b=Se5ropWmH1vt AJw4GozV8L4stdkX0kZIQLuMcAtY39hXbwq2SvitUHCAEUhnB01fJdxrZAcoP2G5IzmcAePllSlWh SiRoUNimbd9dSSde+7WPomWpAX4qoGFTZTGAHz5S4Q3z8UYo2K6SVaLGcgWdOYvpqdzcUwdjhSbcZ P1XwFj1Pxcj/X14meWrEvUrWMzgNGSf9Butcv4u0sCgf7eMbCwug7gVB07pYdW5xjPheicVjRyHA0 I8MxVculIxTGAs1w0ladH+N2D2gZHqs8Q34WU1TCI10yfB/sGezeZUPpIlyEZi6gQRH/UFHzcarxZ Hmol8sEXKo12fRu46BvbHg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPPgm-0006Uu-D0; Fri, 28 Jul 2023 11:47:52 -0400 In-Reply-To: <65da37ba-9f1e-4f42-8a27-2f7b0f60c700@app.fastmail.com> (message from LemonBreezes on Fri, 28 Jul 2023 10:54:02 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266287 Archived-At: > Date: Fri, 28 Jul 2023 10:54:02 -0400 > From: LemonBreezes > Cc: 64914@debbugs.gnu.org > > No, setting gdb-display-io-nopopup to nil does not prevent the program IO from being split off into the > gdb-inferior-io buffer, nor does it prevent the gdb-inferior-io buffer from popping up when debugging is > started. I said set it non-nil, not nil. nil is its default value, under which it does pop up the IO buffer. You want it not to pop up, so you should set the variable to t. > The purpose of setting gdb-display-io-buffer to nil is to prevent the gdb-inferior-io buffer from > being created altogether, instead outputting the program output to the GDB buffer itself. A user in the > Doom Emacs Discord told me this used to be the behavior of gdb-mi.el but that it was changed > without giving the user the option to opt out. I have not investigated that but the comments say that is a > feature of GDB 6.4 onward. If the want the old behavior, why do they use gdb-mi at all? why not use "M-x gud-gdb" instead? That behaves exactly like the old GDB interface. But OK, if someone wants to downgrade gdb-mi this way, why not them have it. So I have a comment to your patch: > +(defcustom gdb-display-io-buffer t > + "When non-nil, display the `gdb-inferior-io' buffer. Otherwise, > +send program output to the GDB buffer." > + :type 'boolean > + :group 'gdb > + :version "30.1") The first line of a doc string should be a single complete sentence. And please describe the behavior in the doc string better: this is not about displaying the IO buffer, this is about not separating the program's I/O from the GDB I/O and not redirecting the program's I/O to a separate buffer. And finally, please accompany your patch with a ChangeLog-style commit log message (see CONTRIBUTE for details, if you need them). Thanks.