From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65198: 29.1; Emacs29.1 crash in function face_for_font Date: Thu, 10 Aug 2023 21:36:26 +0300 Message-ID: <831qgaiw2d.fsf@gnu.org> References: <83r0obi53o.fsf@gnu.org> <83bkfeizgz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31299"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65198@debbugs.gnu.org To: =?UTF-8?Q?=E5=BC=A0=E4=BA=91=E5=B3=B0?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 10 20:37:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUAX4-0007xP-Bu for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Aug 2023 20:37:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUAWy-0007ET-44; Thu, 10 Aug 2023 14:37:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUAWs-00076s-Fy for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 14:37:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUAWs-0007xo-8K for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 14:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUAWs-0004eq-4d for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 14:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Aug 2023 18:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65198 X-GNU-PR-Package: emacs Original-Received: via spool by 65198-submit@debbugs.gnu.org id=B65198.169169257117838 (code B ref 65198); Thu, 10 Aug 2023 18:37:02 +0000 Original-Received: (at 65198) by debbugs.gnu.org; 10 Aug 2023 18:36:11 +0000 Original-Received: from localhost ([127.0.0.1]:44110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUAW3-0004dd-90 for submit@debbugs.gnu.org; Thu, 10 Aug 2023 14:36:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUAVx-0004d0-O8 for 65198@debbugs.gnu.org; Thu, 10 Aug 2023 14:36:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUAVs-0007iz-Cm; Thu, 10 Aug 2023 14:36:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HpqOQJn8cwqZA9bjFsYY/LGQe81v2x2QYKh6uJluu1k=; b=ORik2JJ7zS7HzZzIJfP6 cicmEs8qoBOyFUD3CT1zbynO2UfXMntgAZdCOvP9DfOhJY76ngvG9jxGt0IA9vd++jXq7BnInFFv5 CVor3nmxUFss5aGn+zBzDLUD9CoqjZ/IHOIV0sXo+svgeneCjtTgdVpP8epvYzL2RmEDWmbrHPTBT 6zOZNJtYikS/ZR2NKDUJv3rNuVu9LnWzzvmjXdhjMDSvSKAPgQph3bNfZeZw3cuTrDbQ3qM/2YUUe m7d2eTXKBnIqs5gBIQ9iQFJRd7DH9UuGN0XemdYv6XBJ5mbJCSCWU62zzlAzPA9jEE4FNejLJ9+7W BEPhJroFfL0Bmg==; In-Reply-To: (message from =?UTF-8?Q?=E5=BC=A0=E4=BA=91=E5=B3=B0?= on Fri, 11 Aug 2023 01:58:34 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267159 Archived-At: > From: 张云峰 > Date: Fri, 11 Aug 2023 01:58:34 +0800 > Cc: 65198@debbugs.gnu.org > > 2023-08-11_01-53.png > when popup frame has the warning-icon (marked in picture) , emacs will crash immediately. Can you try the patch below and see if it prevents the crash in these cases? diff --git a/src/xdisp.c b/src/xdisp.c index 9cddcfe..b25bdc7 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -8312,9 +8312,14 @@ get_next_display_element (struct it *it) && success_p && FRAME_WINDOW_P (it->f)) { - struct face *face = FACE_FROM_ID (it->f, it->face_id); + struct face *face = FACE_FROM_ID_OR_NULL (it->f, it->face_id); - if (it->what == IT_COMPOSITION && it->cmp_it.ch >= 0) + if (!face) + { + it->what = IT_GLYPHLESS; + it->glyphless_method = GLYPHLESS_DISPLAY_EMPTY_BOX; + } + else if (it->what == IT_COMPOSITION && it->cmp_it.ch >= 0) { /* Automatic composition with glyph-string. */ Lisp_Object gstring = composition_gstring_from_id (it->cmp_it.id);