From: Eli Zaretskii <eliz@gnu.org>
To: 张云峰 <zhangyunfeng0101@gmail.com>
Cc: 65198@debbugs.gnu.org
Subject: bug#65198: 29.1; Emacs29.1 crash in function face_for_font
Date: Thu, 10 Aug 2023 21:36:26 +0300 [thread overview]
Message-ID: <831qgaiw2d.fsf@gnu.org> (raw)
In-Reply-To: <CA+cG9Gy=KegmHHS931Sp16FBOSrOEAoLKKMiuNx2+qtQ8d7PfA@mail.gmail.com> (message from 张云峰 on Fri, 11 Aug 2023 01:58:34 +0800)
> From: 张云峰 <zhangyunfeng0101@gmail.com>
> Date: Fri, 11 Aug 2023 01:58:34 +0800
> Cc: 65198@debbugs.gnu.org
>
> 2023-08-11_01-53.png
> when popup frame has the warning-icon (marked in picture) , emacs will crash immediately.
Can you try the patch below and see if it prevents the crash in these
cases?
diff --git a/src/xdisp.c b/src/xdisp.c
index 9cddcfe..b25bdc7 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -8312,9 +8312,14 @@ get_next_display_element (struct it *it)
&& success_p
&& FRAME_WINDOW_P (it->f))
{
- struct face *face = FACE_FROM_ID (it->f, it->face_id);
+ struct face *face = FACE_FROM_ID_OR_NULL (it->f, it->face_id);
- if (it->what == IT_COMPOSITION && it->cmp_it.ch >= 0)
+ if (!face)
+ {
+ it->what = IT_GLYPHLESS;
+ it->glyphless_method = GLYPHLESS_DISPLAY_EMPTY_BOX;
+ }
+ else if (it->what == IT_COMPOSITION && it->cmp_it.ch >= 0)
{
/* Automatic composition with glyph-string. */
Lisp_Object gstring = composition_gstring_from_id (it->cmp_it.id);
next prev parent reply other threads:[~2023-08-10 18:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 9:57 bug#65198: 29.1; Emacs29.1 crash in function face_for_font 张云峰
2023-08-10 10:06 ` Eli Zaretskii
[not found] ` <CA+cG9GxATqwi7-aFEvma0zi3AZM5y6eshU510oPFohuKwhHF4w@mail.gmail.com>
2023-08-10 17:22 ` Eli Zaretskii
2023-08-10 17:58 ` 张云峰
2023-08-10 18:36 ` Eli Zaretskii [this message]
2023-08-11 0:15 ` 张云峰
2023-08-11 0:50 ` 张云峰
2023-08-11 6:12 ` Eli Zaretskii
2023-08-11 14:21 ` 张云峰
2023-08-11 14:55 ` 张云峰
2023-08-11 15:30 ` Eli Zaretskii
2023-08-11 16:14 ` 张云峰
2023-08-12 6:39 ` Eli Zaretskii
2023-08-11 15:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qgaiw2d.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65198@debbugs.gnu.org \
--cc=zhangyunfeng0101@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).