From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>,
Jim Porter <jporterbugs@gmail.com>
Cc: emacs@unbit.co.uk, 65245@debbugs.gnu.org
Subject: bug#65245: Possible code removal in eshell/diff (em-unix.el)
Date: Sun, 13 Aug 2023 16:33:30 +0300 [thread overview]
Message-ID: <831qg7cbit.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmmpUojS8HJnTf5-HvcOUH=xWPt5Jfw1hYAwZaXnC+2CaA@mail.gmail.com> (message from Stefan Kangas on Sun, 13 Aug 2023 15:18:29 +0200)
> Cc: 65245@debbugs.gnu.org
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sun, 13 Aug 2023 15:18:29 +0200
>
> Richard Hopkins <emacs@unbit.co.uk> writes:
>
> > I think the use of `compilation-finish-functions' and
> > #'current-window-configuration can be removed from #'eshell/diff
> > as it's no longer called and the intended functionality is achieved
> > elsewhere.
>
> I think your analysis is correct and it holds up in my testing. I
> have therefore removed that part on master along with associated
> cleanups.
It would have been prudent to wait for the Eshell maintainer to chime
in, before rushing with the removal. The suggestion for removal was
posted just one day ago, and that is not long enough to assume the
maintainer is not available.
Jim, any comments on this matter?
next prev parent reply other threads:[~2023-08-13 13:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 10:49 bug#65245: Possible code removal in eshell/diff (em-unix.el) Richard Hopkins
2023-08-13 13:18 ` Stefan Kangas
2023-08-13 13:33 ` Eli Zaretskii [this message]
2023-08-13 16:49 ` Stefan Kangas
2023-08-13 17:32 ` Jim Porter
2023-08-13 17:54 ` Eli Zaretskii
2023-08-14 7:26 ` Michael Albinus
2023-08-14 9:07 ` Stefan Kangas
2023-08-18 4:33 ` Amin Bandali
2023-08-19 10:54 ` Stefan Kangas
2023-08-14 12:04 ` Eli Zaretskii
2023-08-15 3:02 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qg7cbit.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65245@debbugs.gnu.org \
--cc=emacs@unbit.co.uk \
--cc=jporterbugs@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).