From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65414: save-some-buffers-functions are unexpectedly called when save-some-buffers pred is non-nil Date: Sun, 03 Sep 2023 20:44:45 +0300 Message-ID: <831qff6tiq.fsf@gnu.org> References: <871qfxvvw9.fsf@breatheoutbreathe.in> <83lee4vcac.fsf@gnu.org> <87o7ixe1e2.fsf@breatheoutbreathe.in> <83o7ixqatx.fsf@gnu.org> <87fs46cn6u.fsf@breatheoutbreathe.in> <838r9ymfh5.fsf@gnu.org> <874jkmck9j.fsf@breatheoutbreathe.in> <83v8ct9gmg.fsf@gnu.org> <86bkej18pz.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38337"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65414@debbugs.gnu.org, jonas@bernoul.li, monnier@iro.umontreal.ca, joseph@breatheoutbreathe.in To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 19:46:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcrAo-0009lb-HO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 19:46:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcrAi-0003zR-Ea; Sun, 03 Sep 2023 13:46:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcrAh-0003zI-BD for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 13:46:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcrAh-00035r-3A for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 13:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcrAg-0003rC-Dy for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 13:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 17:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65414 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65414-submit@debbugs.gnu.org id=B65414.16937631188216 (code B ref 65414); Sun, 03 Sep 2023 17:46:02 +0000 Original-Received: (at 65414) by debbugs.gnu.org; 3 Sep 2023 17:45:18 +0000 Original-Received: from localhost ([127.0.0.1]:46826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcr9x-00025n-M1 for submit@debbugs.gnu.org; Sun, 03 Sep 2023 13:45:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcr9u-0001dq-MB for 65414@debbugs.gnu.org; Sun, 03 Sep 2023 13:45:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcr9n-0002sS-H2; Sun, 03 Sep 2023 13:45:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jjFcQqOros6MFdpuCbmjL4N4Gp1X+us+jxPONCeAa1E=; b=Gd9RnHgDa8l8 vZO0C5IHK8Gs2yKNhQqUIIxWcwCx9DYjG/HAvCbVvD96kXcyH1U3OyQhl+iqouhv1RHqQgE+MhHRD no87DfEPPLQfapnSRTE9dZqtBDMXdvcQeujhTlRDkoVLaW/5AYXRCTqyo8ydaxdIR++kQ6NCNVYfO fm2CVy6u0rRB8VoU1KC8KkZ6gl51iZMBtphWpl143fYhsGUVGyu2OGAmNJm9H+IDb1Cm37Kwxv/+2 jFhQb/sKr0QcLNvIhoOvIRYlaGFsH7sp5MVnJM0EG15CXhm3Xc02U+dbTvu5ls5cptADFnbjIHTHa lRvKVM157X4/SZGeu5TgPA==; In-Reply-To: <86bkej18pz.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 03 Sep 2023 20:22:56 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269185 Archived-At: > From: Juri Linkov > Cc: Joseph Turner , Stefan Monnier > , jonas@bernoul.li, 65414@debbugs.gnu.org > Date: Sun, 03 Sep 2023 20:22:56 +0300 > > > Hmm... but how to make this change backward-compatible? I mean, if > > there's some function out there that is used in > > save-some-buffers-functions, and it was written to accept only 2 > > arguments, we cannot safely call it with 3 arguments, can we? > > If nothing else helps, just catch 'wrong-number-of-arguments', > then call with an obsolete signature again. I was hoping for a cleaner, more elegant solution. Still do.