From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66211: 30.0.50; C-x v v in vc-diff does not work with lesser versionf of patch Date: Fri, 29 Sep 2023 20:40:23 +0300 Message-ID: <831qegc1yw.fsf@gnu.org> References: <83h6nd1msw.fsf@gnu.org> <78f8becb-7150-33cb-537c-47728b305699@gutov.dev> <835y3typge.fsf@gnu.org> <1e1f0e18-1fe2-4bb4-38f3-1c49de831abc@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="868"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ams@gnu.org, 66211@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 29 19:42:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmHV3-000ATk-96 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Sep 2023 19:42:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmHUu-0006dx-Dt; Fri, 29 Sep 2023 13:41:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmHUp-0006dj-KJ for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 13:41:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmHUp-0001Bn-CH for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 13:41:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qmHV4-0000Gf-0U for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 13:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Sep 2023 17:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66211 X-GNU-PR-Package: emacs Original-Received: via spool by 66211-submit@debbugs.gnu.org id=B66211.1696009267949 (code B ref 66211); Fri, 29 Sep 2023 17:42:01 +0000 Original-Received: (at 66211) by debbugs.gnu.org; 29 Sep 2023 17:41:07 +0000 Original-Received: from localhost ([127.0.0.1]:57171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmHUB-0000FD-7s for submit@debbugs.gnu.org; Fri, 29 Sep 2023 13:41:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmHU6-0000EX-VR for 66211@debbugs.gnu.org; Fri, 29 Sep 2023 13:41:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmHTm-00012n-Kx; Fri, 29 Sep 2023 13:40:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=t+qW/4EDxfAN6wok1LSD9Uqq5kHhEgslwHGCEkQGrtg=; b=OOSn4ZqTlz3L SzyJyUjhyQQij29a41V1iEvOzL4N7WA/xv59SQ48EGv9F2dAWdjxvzSGSqsLSBJWxwPa6/4Kej72w kN4K40m5PRjFAmMViWvUwGzerC/8CM+zo2oA49kyNvdGNdH6HbRC3/2DwqK5J/Q7dsZ96B8FnI/Kl KQ8iPGrKePDSnRgNm7C1IkzMEoEPMTFQmpfPn9p5ODQWUhlR0yQ4nXThnFIWRhfd66eHF1pErw/8g XZVRL+Vkegk13QbOgVhs9T8KMzpJSzd43z7atlMYX6ZdzHSKrQYBmBrJrRGmuU+CDzaZF1rlnHDOW IDMln+kqdKEk1CNKnkCUcA==; In-Reply-To: <1e1f0e18-1fe2-4bb4-38f3-1c49de831abc@gutov.dev> (message from Dmitry Gutov on Fri, 29 Sep 2023 20:27:21 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271521 Archived-At: > Date: Fri, 29 Sep 2023 20:27:21 +0300 > Cc: ams@gnu.org, 66211@debbugs.gnu.org > From: Dmitry Gutov > > On 29/09/2023 18:22, Eli Zaretskii wrote: > >> vc-default-checkin-patch calls 'patch'. It's for other backends. > > > > Why do we call Patch if we have a way to apply hunks in Lisp? Wasn't > > that just discussed in the other thread? > > https://lists.gnu.org/archive/html/emacs-devel/2022-10/msg01353.html That doesn't have a lot in the way of answering my question above. > Anyway, it doesn't seem like 'patch' itself is the problem in this case: When Patch is installed, sure. But using our own code is better because it doesn't need Patch and doesn't have to rely on specific options it may or may not support. I'm not insisting, mind you, just asking. It sounds inconsistent with what we do in similar situations in other places, that's all.