From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: ams@gnu.org, 66211@debbugs.gnu.org
Subject: bug#66211: 30.0.50; C-x v v in vc-diff does not work with lesser versionf of patch
Date: Fri, 29 Sep 2023 20:40:23 +0300 [thread overview]
Message-ID: <831qegc1yw.fsf@gnu.org> (raw)
In-Reply-To: <1e1f0e18-1fe2-4bb4-38f3-1c49de831abc@gutov.dev> (message from Dmitry Gutov on Fri, 29 Sep 2023 20:27:21 +0300)
> Date: Fri, 29 Sep 2023 20:27:21 +0300
> Cc: ams@gnu.org, 66211@debbugs.gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> On 29/09/2023 18:22, Eli Zaretskii wrote:
> >> vc-default-checkin-patch calls 'patch'. It's for other backends.
> >
> > Why do we call Patch if we have a way to apply hunks in Lisp? Wasn't
> > that just discussed in the other thread?
>
> https://lists.gnu.org/archive/html/emacs-devel/2022-10/msg01353.html
That doesn't have a lot in the way of answering my question above.
> Anyway, it doesn't seem like 'patch' itself is the problem in this case:
When Patch is installed, sure. But using our own code is better
because it doesn't need Patch and doesn't have to rely on specific
options it may or may not support.
I'm not insisting, mind you, just asking. It sounds inconsistent with
what we do in similar situations in other places, that's all.
next prev parent reply other threads:[~2023-09-29 17:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 12:17 bug#66211: 30.0.50; C-x v v in vc-diff does not work with lesser versionf of patch Alfred M. Szmidt
2023-09-26 12:38 ` Dmitry Gutov
2023-09-26 12:43 ` Alfred M. Szmidt
2023-09-26 13:38 ` Dmitry Gutov
2023-09-26 15:08 ` Alfred M. Szmidt
2023-09-26 16:30 ` Dmitry Gutov
2023-09-26 16:51 ` Alfred M. Szmidt
2023-10-07 22:33 ` Dmitry Gutov
2023-10-08 5:01 ` Eli Zaretskii
2023-10-14 17:10 ` Dmitry Gutov
2023-09-29 7:05 ` Eli Zaretskii
2023-09-29 10:22 ` Dmitry Gutov
2023-09-29 15:22 ` Eli Zaretskii
2023-09-29 17:27 ` Dmitry Gutov
2023-09-29 17:40 ` Eli Zaretskii [this message]
2023-09-29 18:11 ` Dmitry Gutov
2023-09-29 18:36 ` Alfred M. Szmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qegc1yw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66211@debbugs.gnu.org \
--cc=ams@gnu.org \
--cc=dmitry@gutov.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).