From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65797: `buffer-match-p` should not use `func-arity` Date: Sat, 14 Oct 2023 09:13:19 +0300 Message-ID: <831qdxu3y8.fsf@gnu.org> References: <87v8cmct9b.fsf@breatheoutbreathe.in> <87sf7o38g1.fsf_-_@posteo.net> <871qf1rbdo.fsf@posteo.net> <87o7hz4zg2.fsf@posteo.net> <87sf7b8ker.fsf@posteo.net> <87y1h2blxq.fsf@posteo.net> <874jjqb715.fsf@posteo.net> <0371b6ff-58e4-961e-29c9-4efb65b82185@gutov.dev> <87v8bhtr3k.fsf@breatheoutbreathe.in> <3a282a0b-3efa-ec12-2143-0496ebf6c828@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39926"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65797@debbugs.gnu.org, dmitry@gutov.dev, philipk@posteo.net, mattias.engdegard@gmail.com, joseph@breatheoutbreathe.in To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 14 08:13:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrXuI-000ADf-GE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Oct 2023 08:13:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qrXu7-0005Nx-Pc; Sat, 14 Oct 2023 02:13:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrXu7-0005NU-0D for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 02:13:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qrXu6-0004y4-O9 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 02:13:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qrXuT-0002c5-U6 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 02:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2023 06:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65797 X-GNU-PR-Package: emacs Original-Received: via spool by 65797-submit@debbugs.gnu.org id=B65797.169726403410022 (code B ref 65797); Sat, 14 Oct 2023 06:14:01 +0000 Original-Received: (at 65797) by debbugs.gnu.org; 14 Oct 2023 06:13:54 +0000 Original-Received: from localhost ([127.0.0.1]:47687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrXuM-0002ba-19 for submit@debbugs.gnu.org; Sat, 14 Oct 2023 02:13:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qrXuI-0002bJ-HA for 65797@debbugs.gnu.org; Sat, 14 Oct 2023 02:13:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qrXtp-0004re-7U; Sat, 14 Oct 2023 02:13:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lBDUBQXqelOAZZPdHMzlyuRRjmgXh7O6hkkTqYl56tM=; b=UBqAlekAL44gc1ZSwewP eS9FdK2iXnFxtkkQcAoQiS1HATCEpVbOqAhYsFdo43Jdoaspdzcr2FBkIJ8tzu+Oc2aI/VO1ZgbOa dI1JMYWc+29iZZMQxQpZRP5tIQxYO2Iw/FZG3jpy9SvQGKtwWd4IKyQzO1iPEflN3XQLeal6o9r5v UPjPlTmOTnErqsO11K3bYWPNj47y1zuSay2uTsDJAcYvZsMcBUGIFh92NBoYPh7SXVFOsPjMiad/y 2l/KCoxbaFJ7/6Pfp8N+ev9B9sDI5Vbfk4ocjGZ3FDEX+VtxrKbtlWTwTRXANrN+SHVaI3h7ay7so Xu8ftAD2GyqkdQ==; In-Reply-To: (message from Stefan Monnier on Fri, 13 Oct 2023 11:57:59 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272374 Archived-At: > From: Stefan Monnier > Cc: Joseph Turner , Philip Kaludercic > , Mattias Engdegård > , > Eli Zaretskii , 65797@debbugs.gnu.org > Date: Fri, 13 Oct 2023 11:57:59 -0400 > > >> Then how 'bout something like the patch below which changes the > >> `&optional` into an `&rest` but tries to preserve compatibility with the > >> old calling convention. > > Personally, I figured that using &rest would already help with backward > > compatibility to an extent. > > I don't have a good intuition for how important backward compatibility > is here, so I went for the "safe" choice. But maybe we don't need to go > that far. The patch below keeps the same compatibility hack as we > currently have but doesn't add any new compatibility, so it will break > those uses where `buffer-match-p` is called without additional args but > the predicate function still expects 2 args (where the second is always > nil). Indeed, that case seemes extremely unlikely. > > Eli, Stefan, WDYT? TBH, I have no way of assessing the risks in such a change. Do we have to make this change on the release branch? What bad things will happen if we leave emacs-29 with no changes? The discussion thread is quite long, but my personal take from it is that the arguments for making any changes in the current code are largely theoretical and aesthetic. Am I wrong?