From: Eli Zaretskii <eliz@gnu.org>
To: Cy <cycoding23@gmail.com>, martin rudalics <rudalics@gmx.at>
Cc: 67452@debbugs.gnu.org
Subject: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument
Date: Sun, 26 Nov 2023 13:01:19 +0200 [thread overview]
Message-ID: <831qccbwxs.fsf@gnu.org> (raw)
In-Reply-To: <ee0d53a8-7235-4d2b-94ff-e19c1be616ca@gmail.com> (message from Cy on Sun, 26 Nov 2023 00:42:54 -0800)
> Date: Sun, 26 Nov 2023 00:42:54 -0800
> From: Cy <cycoding23@gmail.com>
>
> I noticed the split-root-window-below and split-root-window-right
> commands fail when passing an argument using C-u:
>
> split-root-window-right: Wrong type argument: number-or-marker-p, (4)
>
> I have edited these functions to remedy this error, and attached a
> patch. I hope that the changes are satisfactory.
I guess we should do this for consistency with other split-window-*
commands? Martin, any reasons the split-root-window-* commands didn't
follow the example of the corresponding split-window-* commands?
In any case, to make the split-root-window-* commands support C-u we
just need to change the interactive spec from "P" to "p", there's no
need for anything more complex.
Thanks.
next prev parent reply other threads:[~2023-11-26 11:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 8:42 bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument Cy
2023-11-26 11:01 ` Eli Zaretskii [this message]
2023-11-27 9:20 ` martin rudalics
2023-11-29 14:16 ` Eli Zaretskii
[not found] ` <handler.67452.D67452.17012674078751.notifdone@debbugs.gnu.org>
2023-12-24 17:41 ` Juri Linkov
2023-12-25 13:00 ` Eli Zaretskii
2023-12-30 7:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qccbwxs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67452@debbugs.gnu.org \
--cc=cycoding23@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).