From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67452: 30.0.50; [PATCH] Make split-root-window functions handle argument Date: Mon, 25 Dec 2023 15:00:49 +0200 Message-ID: <831qbabfni.fsf@gnu.org> References: <838r6g7ih8.fsf@gnu.org> <86sf3rqyzy.fsf_-_@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3215"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67452@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 25 14:02:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rHkaw-0000fA-KQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Dec 2023 14:02:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rHkan-00033E-JE; Mon, 25 Dec 2023 08:02:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHkaj-00032a-4s for bug-gnu-emacs@gnu.org; Mon, 25 Dec 2023 08:01:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rHkah-0007Il-MN for bug-gnu-emacs@gnu.org; Mon, 25 Dec 2023 08:01:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rHkao-0001C5-4u for bug-gnu-emacs@gnu.org; Mon, 25 Dec 2023 08:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Dec 2023 13:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67452-submit@debbugs.gnu.org id=B67452.17035092663190 (code B ref 67452); Mon, 25 Dec 2023 13:02:02 +0000 Original-Received: (at 67452) by debbugs.gnu.org; 25 Dec 2023 13:01:06 +0000 Original-Received: from localhost ([127.0.0.1]:54129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHkZu-0000ob-2M for submit@debbugs.gnu.org; Mon, 25 Dec 2023 08:01:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rHkZs-0000dE-F9 for 67452@debbugs.gnu.org; Mon, 25 Dec 2023 08:01:05 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHkZg-0006za-8m; Mon, 25 Dec 2023 08:00:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h2pn51IY4qRTlgW8NlhlJ68br3krFH/2/gPhHBBb8YY=; b=AXKkV/3j4AjH jIKehv1azgbjAVchIYfpyN1Lg2BycvaDGKWOHF7vkvD+2cJXsmMIcW5rLTlZflr8D+muWYl7hpMja ZmP06Ze6ryeBium9/lFcBen4/Wun2TJkyqcO1jfYELVZB4kg9VqPLLVTuqb9l0Ht93p+EEAbvU3tN Ry8EZp6T0iHbrSqySW7h9IzRNHdnoZijvK+7qI8e609e53DfcXZU+pbNkPs2IicmvtjAVNvce37Ua O0ocT8RBMBXgBStUYqvcGU12jWpixc5DTvMBHNXh76iqTowZIYIv4qUNrLBsw/70SL6yveYKasjCb kPy8LISv98bSF1DhIfcilA==; In-Reply-To: <86sf3rqyzy.fsf_-_@mail.linkov.net> (message from Juri Linkov on Sun, 24 Dec 2023 19:41:37 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276848 Archived-At: > From: Juri Linkov > Date: Sun, 24 Dec 2023 19:41:37 +0200 > > > Thanks, I've now installed the change on the emacs-29 branch, using > > the "p" interactive spec, and I'm closing this bug. > > The commit cd477bf07d8 broke normal use of split-root-window commands > without arguments: > > 0. emacs-29 -Q > 1. C-x 2 > 2. C-x w 3 > > Debugger entered--Lisp error: (error "Window # too small for splitting") > error("Window %s too small for splitting" #) > split-window(# 1 t) > split-window-right(1 #) > split-root-window-right(1) > funcall-interactively(split-root-window-right 1) > command-execute(split-root-window-right) > > because the "p" interactive spec uses SIZE=1. Thanks, should be fixed now on the emacs-29 branch.