From: Ken Brown <kbrown@cornell.edu>
To: 49524@debbugs.gnu.org
Subject: bug#49524: 28.0.50; make-serial-process is not portable
Date: Sun, 11 Jul 2021 11:24:58 -0400 [thread overview]
Message-ID: <82e72be1-9907-c08f-0c1d-d625e914a902@cornell.edu> (raw)
Fmake_serial_process calls Fserial_process_configure, which calls
serial_configure, which calls cfsetspeed with the speed argument equal to the
numerical baud rate (e.g., 9600). But the documentation of cfsetspeed says that
the speed argument must be one of the Bnnn constants defined in termios.h (e.g.,
B9600). See, for example,
https://man7.org/linux/man-pages/man3/termios.3.html
This incorrect call of cfsetspeed happens to succeed on GNU/Linux because
glibc's cfsetspeed allows the argument to be the numerical baud rate, which it
converts to the appropriate Bnnn constant. But I don't think emacs should be
relying on this undocumented behavior. In particular, this doesn't work on
Cygwin. And it wouldn't even work on GNU/Linux if emacs used the cfsetspeed
replacement defined in sysdep.c instead of glibc's cfsetspeed.
I think the way to fix this is to imitate the glibc code that converts the baud
rate to a Bnnn constant, but maybe someone has a better idea.
By the way, I came across this issue while investigating the failure of
process-tests/fd-setsize-no-crash/make-serial-process on Cygwin.
next reply other threads:[~2021-07-11 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 15:24 Ken Brown [this message]
2021-07-11 16:24 ` bug#49524: 28.0.50; make-serial-process is not portable Eli Zaretskii
2021-07-12 13:27 ` Ken Brown
2021-07-12 21:35 ` Ken Brown
2021-07-13 11:19 ` Eli Zaretskii
2021-07-13 13:11 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82e72be1-9907-c08f-0c1d-d625e914a902@cornell.edu \
--to=kbrown@cornell.edu \
--cc=49524@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).