From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#43609: 28.0.50; eldoc-documentation-function Date: Tue, 29 Sep 2020 18:23:04 +0300 Message-ID: <82a64fee-ecdc-a24f-891a-c1ad04ed7f78@yandex.ru> References: <2e610c3f-6e5f-c7dd-af2e-aeb5e20d8664@gmx.at> <89a118cf-65e1-5e9f-0884-577a52ca115e@gmx.at> <74e25bf7-e7ad-a0e7-3fe5-36ea6afbace5@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16376"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: martin rudalics , 43609@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 29 17:24:59 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNHUw-00049u-TL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Sep 2020 17:24:58 +0200 Original-Received: from localhost ([::1]:56196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNHUv-00055T-TT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Sep 2020 11:24:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNHU2-0004Sa-Fy for bug-gnu-emacs@gnu.org; Tue, 29 Sep 2020 11:24:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45390) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNHU2-0000ie-5r for bug-gnu-emacs@gnu.org; Tue, 29 Sep 2020 11:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNHU2-0004qF-1r for bug-gnu-emacs@gnu.org; Tue, 29 Sep 2020 11:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Sep 2020 15:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43609 X-GNU-PR-Package: emacs Original-Received: via spool by 43609-submit@debbugs.gnu.org id=B43609.160139299618557 (code B ref 43609); Tue, 29 Sep 2020 15:24:02 +0000 Original-Received: (at 43609) by debbugs.gnu.org; 29 Sep 2020 15:23:16 +0000 Original-Received: from localhost ([127.0.0.1]:56936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNHTI-0004pF-IV for submit@debbugs.gnu.org; Tue, 29 Sep 2020 11:23:16 -0400 Original-Received: from mail-ej1-f42.google.com ([209.85.218.42]:38015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNHTF-0004p1-EC for 43609@debbugs.gnu.org; Tue, 29 Sep 2020 11:23:15 -0400 Original-Received: by mail-ej1-f42.google.com with SMTP id dd13so2846632ejb.5 for <43609@debbugs.gnu.org>; Tue, 29 Sep 2020 08:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QuopEPVFXkDm5M89kbbiUAacPtx8VVozUKS1MrMmRTA=; b=Xqjl/aMZ9RtefblRyoBuE1HGF9KFeAjJPdlFpus/5sdypp/en5bJBpKgSLQEI34LmX mF5pHgiafMSk/NAZfh2S82dpyPnWbh3ewR6BccFCBR018Il9ye4p0elUTkcNnepP1dJh odjFNJoR0mQcVA8C/R/rJyEy4wYHETvStGSEBqkUcAc0918WL3VmqXzDqED50n0RXMvg QDQQeps+q7ZKHRWbqDHKhwpF3NY7dszTSTvfuJnW4eeT5Fw7WVhWt1plzmDY+MlXpXjW qqzJpnkAc0uyTnft61p8jz4yfqVLtUDQbGXBQiGZX02pDaQaYEsCgFUPIrdi8IOUoyyH E9dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QuopEPVFXkDm5M89kbbiUAacPtx8VVozUKS1MrMmRTA=; b=lEGZxyMuC1qG9vfPTC7ZrUlUyA6t9bdBibBLo6VZB8+mKW21J+ocTDk8ZhAi6ipqql Au++rXfv/z4vL3TmtU2uMKQkXJ/HvsEIRG9aa4d53Kg+88FV5bpKPRIElDIrQv3P0Ett k3QQm7K90fFZj5ohHXxf169gSZjby0ftqBzjH9N62LA0i5XksFCVdNV70CTcWGe05FDn aowtiaGtaf1J1oXl7xC7dn+uGfIWMHUZ7QFxmqjMK9BI2wf1s6hYcofw/FzAcFnPTdUi 7o++ev6t2442jVpOmbUMl7kAeS7HD3MIchDW53ComAyJ2m0ACPteuUEugegZnZLEIIDF QKsg== X-Gm-Message-State: AOAM5329rm3gVpu0eSBVVjMMC1irCcFMlDMUw4sW9BYnXHt5aheZTuyi pB57Xx43QsxJyzKBnvWtf3FPGTv92LXMEg== X-Google-Smtp-Source: ABdhPJwy6yzA3shSrlos8yYznLCj708SNFrzXGiCo9SSsGnG+xA7OcVOVpxe3LgvqpzGuQ2O31ir1g== X-Received: by 2002:a17:906:1f08:: with SMTP id w8mr4342605ejj.181.1601392987185; Tue, 29 Sep 2020 08:23:07 -0700 (PDT) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id r8sm6071728edy.87.2020.09.29.08.23.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2020 08:23:05 -0700 (PDT) In-Reply-To: <74e25bf7-e7ad-a0e7-3fe5-36ea6afbace5@gmx.at> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189274 Archived-At: On 29.09.2020 18:09, martin rudalics wrote: > > Hooks is a list of functions. They get called to fetch the doc > > information. And now there is some logic called "strategies" that > > combines the results. > > So 'eldoc-documentation-functions' just holds a list of functions I > could call in order to get the documentation of the object at point? > How does the notion of a "hook" enter here? It's a list that is usually manipulated with 'add-hook'. Like it often done with other variables named '*-functions'. > > No, the hook functions are written already. They are basically a list > > of functions that were previously the values of > > eldoc-documentation-function. Except it's now a list. *And* they use > > an asynchronous convention where the first argument they receive is a > > callback. > > Is there a way to drop that callback?  I just want an immediate answer. With my proposal, there would have been. See the original discussion. > > It should work if your package learns to make use of the new > > eldoc-documentation-functions hook. Or eldoc-documentation-strategy, > > which calls them. > > 'eldoc-documentation-strategy' is a variable so it's probably the > function that is the value of that variable and it should suffice to use > 'eldoc-documentation-default'.  But this failed here before. You should probably honor this variable, if the expectation is to generally follow ElDoc's behavior but display the documentation in a different place, e.g. using a popup.