From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#5264: 23.1; `repeat' should not hard-code the set of affected commands Date: Thu, 24 Dec 2009 07:30:20 -0800 Message-ID: <829F48EB8E68453A956D490A63FD97CB@us.oracle.com> Reply-To: Drew Adams , 5264@debbugs.gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1261669074 1903 80.91.229.12 (24 Dec 2009 15:37:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Dec 2009 15:37:54 +0000 (UTC) To: Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 24 16:37:47 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NNpl4-0006MG-1p for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Dec 2009 16:37:46 +0100 Original-Received: from localhost ([127.0.0.1]:54281 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NNpl4-00035h-Au for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Dec 2009 10:37:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NNpkf-0002pv-Tq for bug-gnu-emacs@gnu.org; Thu, 24 Dec 2009 10:37:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NNpkb-0002lg-Bu for bug-gnu-emacs@gnu.org; Thu, 24 Dec 2009 10:37:21 -0500 Original-Received: from [199.232.76.173] (port=34432 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NNpka-0002lW-Te for bug-gnu-emacs@gnu.org; Thu, 24 Dec 2009 10:37:16 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49872) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NNpka-0007du-Jn for bug-gnu-emacs@gnu.org; Thu, 24 Dec 2009 10:37:16 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NNpgU-0003Q6-V5; Thu, 24 Dec 2009 10:33:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Mail-Followup-To: "Drew Adams" , 5264@debbugs.gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Dec 2009 15:33:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: report 5264 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.126166876313117 (code B ref -1); Thu, 24 Dec 2009 15:33:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Dec 2009 15:32:43 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NNpgB-0003PV-2i for submit@debbugs.gnu.org; Thu, 24 Dec 2009 10:32:43 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NNpg8-0003PB-TM for submit@debbugs.gnu.org; Thu, 24 Dec 2009 10:32:41 -0500 Original-Received: from mail.gnu.org ([199.232.76.166]:56316 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NNpfy-0001HX-In for submit@debbugs.gnu.org; Thu, 24 Dec 2009 10:32:31 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NNpfu-0007BK-Ug for submit@debbugs.gnu.org; Thu, 24 Dec 2009 10:32:30 -0500 Original-Received: from lists.gnu.org ([199.232.76.165]:40747) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NNpfu-0007BE-OR for submit@debbugs.gnu.org; Thu, 24 Dec 2009 10:32:26 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NNpfu-00010D-Kf for bug-gnu-emacs@gnu.org; Thu, 24 Dec 2009 10:32:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NNpfp-0000yF-Vj for bug-gnu-emacs@gnu.org; Thu, 24 Dec 2009 10:32:26 -0500 Original-Received: from [199.232.76.173] (port=34527 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NNpfp-0000y7-MU for bug-gnu-emacs@gnu.org; Thu, 24 Dec 2009 10:32:21 -0500 Original-Received: from rcsinet12.oracle.com ([148.87.113.124]:35165) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NNpfp-0007Ae-AK for bug-gnu-emacs@gnu.org; Thu, 24 Dec 2009 10:32:21 -0500 Original-Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet12.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id nBOFWH2c011246 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 24 Dec 2009 15:32:18 GMT Original-Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id nBODf2oX012956 for ; Thu, 24 Dec 2009 15:32:16 GMT Original-Received: from abhmt012.oracle.com by acsmt353.oracle.com with ESMTP id 1224973391261668618; Thu, 24 Dec 2009 07:30:18 -0800 Original-Received: from dradamslap1 (/141.144.169.90) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 24 Dec 2009 07:30:18 -0800 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcqErgCfNNgUAAl6TMiS09oG56VnLg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt358.oracle.com [141.146.40.158] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.4B338980.01F3:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -5.6 (-----) Resent-Date: Thu, 24 Dec 2009 10:33:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33745 Archived-At: emacs -Q In the definition of command `repeat': (if (memq last-repeatable-command '(exit-minibuffer minibuffer-complete-and-exit self-insert-and-exit)) This list of affected commands should not be hard-coded. If user code uses different functions from `exit-minibuffer' and `minibuffer-complete-and-exit', then users must redefine `repeat' to accommodate this command difference. The `repeat' definition should be more flexible than that. This list of commands should be treated the same way we treat the list of dangerous commands (`repeat-too-dangerous'): define a variable whose value is the list of commands - do not hard-code the list. In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)'