From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#19727: 25.0.50; setting a todo item to done puts point at the end of the buffer Date: Thu, 29 Jan 2015 11:10:47 +0100 Message-ID: <827fw5oq1k.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1422551474 13521 80.91.229.3 (29 Jan 2015 17:11:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 29 Jan 2015 17:11:14 +0000 (UTC) To: 19727@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 29 18:11:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YGsca-00042K-LD for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Jan 2015 18:11:12 +0100 Original-Received: from localhost ([::1]:32768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGscZ-0001PC-Tq for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Jan 2015 12:11:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGscV-0001Ov-0c for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 12:11:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGscQ-0008JK-1F for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 12:11:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37989) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGscP-0008JG-U8 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 12:11:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YGscP-0001jZ-O5 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 12:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jan 2015 17:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 19727 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14225514106601 (code B ref -1); Thu, 29 Jan 2015 17:11:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Jan 2015 17:10:10 +0000 Original-Received: from localhost ([127.0.0.1]:57462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGsba-0001iO-5y for submit@debbugs.gnu.org; Thu, 29 Jan 2015 12:10:10 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49911) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YGm49-0006BE-Aa for submit@debbugs.gnu.org; Thu, 29 Jan 2015 05:11:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGm42-0006Q2-T0 for submit@debbugs.gnu.org; Thu, 29 Jan 2015 05:11:07 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGm42-0006Py-QJ for submit@debbugs.gnu.org; Thu, 29 Jan 2015 05:11:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGm3y-0007L2-Vq for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 05:11:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGm3u-0006P6-N6 for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 05:11:02 -0500 Original-Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:36445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGm3u-0006P2-Fy for bug-gnu-emacs@gnu.org; Thu, 29 Jan 2015 05:10:58 -0500 Original-Received: by mail-we0-f181.google.com with SMTP id k48so23085118wev.12 for ; Thu, 29 Jan 2015 02:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=E2vabU2xZhLCz6OZsO9SOhLk+CeWvLWQynv02E/0QbA=; b=hAgvU0yHQRIohIp1lEsM1HOvVa+75nFdTloEAzCpGAwJoY9kPDTvPg6f9Qb2zuj58S mcRo84P6CTK4mouwtyQ9xhh2u6AxkpxX6PFZd2+LZv90joJdybhlDCf2mAwDcAHny51z UZO/mAmWkzzCJIdZdn1ssmCLsElkSsI6TQbIi3vpRjj+PARQK+RiB86/V1yAmInpM6jp 1HtWJNkJP28dlqWEGNBnT218sAuAtvgu1eg4T/GWffeDkWIG0LNHe47WSV+prpoeLZQG noFTmqfVhUEPH/HAL6gQWSVxfVL8gq4RUaOGXFakfNDDLsEEHG6srueMVRLfG5Xi6wdx KsuQ== X-Received: by 10.194.84.176 with SMTP id a16mr16135574wjz.113.1422526257378; Thu, 29 Jan 2015 02:10:57 -0800 (PST) Original-Received: from RPLUIM (vav06-1-78-207-202-9.fbx.proxad.net. [78.207.202.9]) by mx.google.com with ESMTPSA id p6sm1798540wia.14.2015.01.29.02.10.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jan 2015 02:10:56 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Thu, 29 Jan 2015 12:10:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98874 Archived-At: --=-=-= Content-Type: text/plain Hi, when I set an item to done in a todo-mode buffer, point ends up at the end of the buffer, which is somewhat surprising. Attached patch remembers where point was, and restores it. Regards Robert In GNU Emacs 25.0.50.6 (i686-pc-cygwin) of 2015-01-28 on RPLUIM Repository revision: 8a8bd38fedb89b2d04cca2419698813a22862c3b Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --with-w32 --with-wide-int' --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=todo-mode-done-restore-point.patch diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 90681c8..060cbf7 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2015-01-26 Robert Pluim + + * calendar/todo-mode.el (todo-item-done): Initialize opoint so + that point stays where it is when setting items to DONE. + 2015-01-28 Tassilo Horn * textmodes/reftex.el (reftex-syntax-table-for-bib): Give ( and ) diff --git a/lisp/calendar/todo-mode.el b/lisp/calendar/todo-mode.el index 7ca57a4..2fb7e2e 100644 --- a/lisp/calendar/todo-mode.el +++ b/lisp/calendar/todo-mode.el @@ -2816,7 +2816,8 @@ (defun todo-item-done (&optional arg) (goto-char (point-min)) (re-search-forward todo-done-string-start nil t))) (buffer-read-only nil) - item done-item opoint) + item done-item + (opoint (point))) ;; Don't add empty comment to done item. (setq comment (unless (zerop (length comment)) (concat " [" todo-comment-string ": " comment "]"))) --=-=-=--