From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Date: Tue, 2 Aug 2022 19:42:22 -0700 Message-ID: <825425fe-331f-11b8-94a4-6f899162ec4c@gmail.com> References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <87r11ycbfs.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10242"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56896@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 03 04:43:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJ4Lq-0002VE-0I for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Aug 2022 04:43:14 +0200 Original-Received: from localhost ([::1]:53104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJ4Ln-000497-Jt for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 22:43:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJ4Le-00048X-CY for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 22:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55882) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJ4Le-0001Hq-4L for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 22:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJ4Ld-0004cH-S8 for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 22:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Aug 2022 02:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.165949455217709 (code B ref 56896); Wed, 03 Aug 2022 02:43:01 +0000 Original-Received: (at 56896) by debbugs.gnu.org; 3 Aug 2022 02:42:32 +0000 Original-Received: from localhost ([127.0.0.1]:45631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ4LA-0004bZ-0Z for submit@debbugs.gnu.org; Tue, 02 Aug 2022 22:42:32 -0400 Original-Received: from mail-pg1-f181.google.com ([209.85.215.181]:38880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ4L7-0004bL-KH for 56896@debbugs.gnu.org; Tue, 02 Aug 2022 22:42:30 -0400 Original-Received: by mail-pg1-f181.google.com with SMTP id h23so1736824pgv.5 for <56896@debbugs.gnu.org>; Tue, 02 Aug 2022 19:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc; bh=8T3yQ/y3tURoTxExrlUMwX9mgI7TSZvf9ynYNa65I9I=; b=XaalbHLtscgLuPdVZHZF1JO/wKEW+2w0MH+cBnkkZBDxrTffdVHQj8WSKLfM7AbiRW 0Spcv+4u/+wFiyDu2PY5GNv+pEk35DXjib+xklNHIxHuU7LwV5F2yywjW8O0fv5xQPUd MhEjoCPpH6bSu+ERPw81mx0tVpWi2pM6sMkvXjvbBuAe5DGuPOljqbox8+333JqKl9Rl w9bD2zchOFNloFZstbG0isRdO4P1KwPsY0fEOoYPCa3nzOdMGvrr1uLjT5ghAGfl57oJ QqMOhKcwbvwXQ52S9mL2C3acfQuXFeo0Oy82pgHYa7dO3pReUHq9Rsr4gwlhU9FjcBO7 4DnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc; bh=8T3yQ/y3tURoTxExrlUMwX9mgI7TSZvf9ynYNa65I9I=; b=S2Is3i7gdKge8mF018h3pMgHGIctKNk6jTTZJ8HPHZsFpiXfJoYG4w/b75fd8mOv6c tsVWX4QhznmfzG8I/wWVs7O3HljB08A4vSX7gJm6LWFbdeANldL/1EHXaIS8AYbZxJcz B3C3ILPcB8hupWdGqYTSvb3dVmDjWUnbiJW3A/GtUZBiEAWS1w6rHWWvCaklmgvW3kV1 oUiBWUwGAEPL9R7UvyjBMKllD+XN9qJ1EMerX46GYsp3lYFKC+fwcZ9p8RyYYbNZV3Hq VkqE1DgRwcZ3YZhNtHS3aVq202AyBcSYZUYWIFB0fAn4pKCoLrwShTH+/UrmRgscwtfh 7tmw== X-Gm-Message-State: AJIora/Lv8zcwwv0EmXKbgF9Sjv1Ep9UQBz2LYli9lz9YSRQ9l49bYjc wBzFlKneFwIbqslNSXIcsI8jQKeLFI4= X-Google-Smtp-Source: AA6agR5tF4NY0+PFKjLFqwKQQFRHsafqFS4V+JkninympfCW6aOpU9dJrLP9PMVnxEYC6IOHdiE5FQ== X-Received: by 2002:a05:6a00:a8e:b0:527:9d23:c613 with SMTP id b14-20020a056a000a8e00b005279d23c613mr23955512pfl.53.1659494543569; Tue, 02 Aug 2022 19:42:23 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id q38-20020a635c26000000b00419acadde52sm9962794pgb.46.2022.08.02.19.42.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 19:42:22 -0700 (PDT) In-Reply-To: <87r11ycbfs.fsf@yahoo.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238609 Archived-At: On 8/2/2022 7:23 PM, Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > What build of Emacs are you using? > I see that the background of the fringe bitmap doesn't match the fringe > itself, which is usually a bug. I think you're correct that it's a bug, although it looks like a fairly simple one. Here's the relevant bit from the definition of `bookmark-face': (((class color) (background light)) :background "White" :foreground "DarkOrange1") (((class color) (background dark)) :background "Black" :foreground "DarkOrange1")) The :background should probably be removed and replaced with :distant-foreground (I assume the :background was specified just in case the default background was too close to DarkOrange1, so we shouldn't regress that). I can fix this part at the same time as the rest of this bug. Thanks for pointing it out, since I probably would have glossed over this entirely otherwise (I don't usually use the default theme, so I hadn't seen this issue before).