From: Jim Porter <jporterbugs@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: 56896@debbugs.gnu.org
Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark
Date: Tue, 2 Aug 2022 19:42:22 -0700 [thread overview]
Message-ID: <825425fe-331f-11b8-94a4-6f899162ec4c@gmail.com> (raw)
In-Reply-To: <87r11ycbfs.fsf@yahoo.com>
On 8/2/2022 7:23 PM, Po Lu via Bug reports for GNU Emacs, the Swiss army
knife of text editors wrote:
> What build of Emacs are you using?
> I see that the background of the fringe bitmap doesn't match the fringe
> itself, which is usually a bug.
I think you're correct that it's a bug, although it looks like a fairly
simple one. Here's the relevant bit from the definition of `bookmark-face':
(((class color)
(background light))
:background "White" :foreground "DarkOrange1")
(((class color)
(background dark))
:background "Black" :foreground "DarkOrange1"))
The :background should probably be removed and replaced with
:distant-foreground (I assume the :background was specified just in case
the default background was too close to DarkOrange1, so we shouldn't
regress that).
I can fix this part at the same time as the rest of this bug. Thanks for
pointing it out, since I probably would have glossed over this entirely
otherwise (I don't usually use the default theme, so I hadn't seen this
issue before).
next prev parent reply other threads:[~2022-08-03 2:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 19:13 bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Jim Porter
2022-08-02 19:18 ` Eli Zaretskii
2022-08-02 20:05 ` Jim Porter
2022-08-03 2:28 ` Eli Zaretskii
2022-08-04 3:24 ` Jim Porter
2022-08-04 6:53 ` Eli Zaretskii
2022-08-04 6:57 ` Lars Ingebrigtsen
2022-08-05 4:41 ` Jim Porter
2022-08-13 21:59 ` bug#56896: 29.0.50; [PATCHv3] " Jim Porter
2022-08-15 6:44 ` Lars Ingebrigtsen
2022-08-16 4:17 ` Jim Porter
2022-08-21 16:23 ` Juri Linkov
2022-08-02 20:10 ` bug#56896: 29.0.50; [PATCH] " Drew Adams
2022-08-03 2:23 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-08-03 2:42 ` Jim Porter [this message]
2022-08-03 4:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=825425fe-331f-11b8-94a4-6f899162ec4c@gmail.com \
--to=jporterbugs@gmail.com \
--cc=56896@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).