From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Ponce via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Date: Thu, 9 Jan 2025 11:01:40 +0100 Message-ID: <822bd2c9-7463-4c55-89c2-2eabd990944d@orange.fr> References: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> <8cc723b7-c6c5-450d-9832-9039362d63a5@gmail.com> <86ed1c31o6.fsf@gnu.org> Reply-To: David Ponce Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------2v1xAl04xulOinUXJ106pOFF" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40777"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 73178@debbugs.gnu.org To: Eli Zaretskii , Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 09 11:02:19 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVpMo-000ATB-Ui for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jan 2025 11:02:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVpMc-0003Wk-NA; Thu, 09 Jan 2025 05:02:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVpMY-0003WR-Ll for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 05:02:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVpMY-0005oV-Ck for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 05:02:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=p57XV3i2jfFHotpMBY8l4IfzEZJANC9Z+Fnu1v7ggB8=; b=a/cNvYOwj6AVbaZ3sveGjYlTcsD9Vpkz4ikulxpEwGtuWr4nKp1f76gumdy7YQRa4ZS8AHQc1Ycj3JtNJoqC7dstwGb0p4cISVG2nZbRa5nM6lc9ctuoDBjMFWLswPGujY6sqY/jbzRcLWHoZcWlqfHLwhF3anwiSXhFB3aQmwx3sJXxe0KvHoug3i0SljdVko9xzZ3R/82l9YmcZzIUj7bClnU/43QUXL2yXZ7j6Gbj9Ps2OF9xju9c2wNSVpfA+csyVSWuTclbhLLv5slABhFU0H9c17BmLMDvKi9/b5r3eSIUl5vBzZB0aps/yr9IN7O97iS4+v2KKok4ansFgg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVpMY-00066z-16 for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 05:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2025 10:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73178-submit@debbugs.gnu.org id=B73178.173641691123476 (code B ref 73178); Thu, 09 Jan 2025 10:02:01 +0000 Original-Received: (at 73178) by debbugs.gnu.org; 9 Jan 2025 10:01:51 +0000 Original-Received: from localhost ([127.0.0.1]:50493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVpMN-00066a-8L for submit@debbugs.gnu.org; Thu, 09 Jan 2025 05:01:51 -0500 Original-Received: from smtp-81.smtpout.orange.fr ([80.12.242.81]:40809 helo=smtp.smtpout.orange.fr) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVpMK-00066P-2r for 73178@debbugs.gnu.org; Thu, 09 Jan 2025 05:01:50 -0500 Original-Received: from [192.168.1.21] ([90.112.40.65]) by smtp.orange.fr with ESMTPA id VpMDt0ndVgrRVVpMGtrrou; Thu, 09 Jan 2025 11:01:46 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1736416906; bh=p57XV3i2jfFHotpMBY8l4IfzEZJANC9Z+Fnu1v7ggB8=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=aUvBMPSSybw7kmZvFhAxozQEV3xwkQRpbVRZhXaQmYXi/Jrhl8c/DcG9wDvqTs22T g7dA7ihnomiYiv0v8yw/xs10VXKo1bqi8ZgI6237MoovamotdHm/ka4QRsj8q4ICYg 10YtE9Y64Mny5BqO2F8Ygq+xyxWwPViBPdW0OzOTGV2MXCufLEEeGixJlkRrmclyMx jUsZ/p+bbocZ9IfJ8eah3EsNbvlgPxxvNS5bHmPrw5ko0M2YMSGZqkFhj/3yJa2UjM 2ylxb5YilaOAjd8HJEK0p4+MejkS1D2vEPbl2XndEXY5W3UjjG5G/KQMq7Rd/Unloc FffkL/iFKZSoA== X-ME-Helo: [192.168.1.21] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Thu, 09 Jan 2025 11:01:46 +0100 X-ME-IP: 90.112.40.65 Content-Language: fr, en-US In-Reply-To: <86ed1c31o6.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298826 Archived-At: This is a multi-part message in MIME format. --------------2v1xAl04xulOinUXJ106pOFF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-01-09 08:07, Eli Zaretskii wrote: >> Date: Wed, 8 Jan 2025 10:59:27 -0300 >> Cc: Eli Zaretskii >> From: Mauro Aranda >> [...] >> I think this is an improvement. Thanks David. > > Thanks for the review. > > I wanted to install this, but byte-compiler produces a warning: > > ELC cus-edit.elc > > In toplevel form: > cus-edit.el:5595:20: Warning: reference to free variable `custom-icon--texts-widget' > > Is that a typo, and you actually meant custom-icon--texts-sub-type? > > Also, could you please accompany the patch with the ChangeLog-style > commit log message (see CONTRIBUTE for the details)? Otherwise, I > will have to write the log message manually when installing your > changes. > > Thanks. Hello Eli, Hmm, it seems you didn't install the correct patch? I attached the correct patch (V2) which applies cleanly for me. Also below is my proposed ChangeLog. Thank you, and thanks Mauro for your review. 2025-01-09 David Ponce Improve usability of the widget used to customize icon. * lisp/cus-edit.el (custom-icon--images-sub-type) (custom-icon--emojis-sub-type, custom-icon--symbols-sub-type) (custom-icon--texts-sub-type): New constant. (custom-icon--type): New constant. (custom-icon-value-create): Use it. --------------2v1xAl04xulOinUXJ106pOFF Content-Type: text/x-patch; charset=UTF-8; name="improve-widget-to-customize-icon-V2.patch" Content-Disposition: attachment; filename="improve-widget-to-customize-icon-V2.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvY3VzLWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0LmVsCmluZGV4 IDNhYjVmMTE1MzJlLi5mZDc5MGIxODYzMCAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZWRpdC5l bAorKysgYi9saXNwL2N1cy1lZGl0LmVsCkBAIC01NTI1LDYgKzU1MjUsNTMgQEAgY3VzdG9t LWljb24tZXh0ZW5kZWQtbWVudQogICAiQSBtZW51IGZvciBgY3VzdG9tLWljb24nIHdpZGdl dHMuCiBVc2VkIGluIGBjdXN0b20taWNvbi1hY3Rpb24nIHRvIHNob3cgYSBtZW51IHRvIHRo ZSB1c2VyLiIpCiAKKyhkZWZjb25zdCBjdXN0b20taWNvbi0taW1hZ2VzLXN1Yi10eXBlCisg ICcobGlzdCA6Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiSW1hZ2Vz IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIGltYWdlKQorICAgICAgICAgKHJlcGVhdCA6 dGFnICJWYWx1ZXMiCisgICAgICAgICAgICAgICAgIChzdHJpbmcgOnRhZyAiSW1hZ2UgZmls ZW5hbWUiKSkKKyAgICAgICAgIChwbGlzdCAgOnRhZyAiSW1hZ2UgYXR0cmlidXRlcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1lbW9qaXMtc3ViLXR5cGUKKyAgJyhsaXN0IDpm b3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJDb2xvcmZ1bCBFbW9qaXMi CisgICAgICAgICAoY29uc3QgIDp0YWcgIiIgZW1vamkpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJFbW9qaSB0ZXh0 IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIkVtb2ppIHRleHQgcHJvcGVydGllcyIpKSkK KworKGRlZmNvbnN0IGN1c3RvbS1pY29uLS1zeW1ib2xzLXN1Yi10eXBlCisgICcobGlzdCA6 Zm9ybWF0ICIleyV0JX06XG4ldlxuIgorICAgICAgICAgOnRhZyAiTW9ub2Nocm9tZSBTeW1i b2xzIgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHN5bWJvbCkKKyAgICAgICAgIChyZXBl YXQgOnRhZyAiVmFsdWVzIgorICAgICAgICAgICAgICAgICAoc3RyaW5nIDp0YWcgIlN5bWJv bCB0ZXh0IikpCisgICAgICAgICAocGxpc3QgIDp0YWcgIlN5bWJvbCB0ZXh0IHByb3BlcnRp ZXMiKSkpCisKKyhkZWZjb25zdCBjdXN0b20taWNvbi0tdGV4dHMtc3ViLXR5cGUKKyAgJyhs aXN0IDpmb3JtYXQgIiV7JXQlfTpcbiV2XG4iCisgICAgICAgICA6dGFnICJUZXh0cyBPbmx5 IgorICAgICAgICAgKGNvbnN0ICA6dGFnICIiIHRleHQpCisgICAgICAgICAocmVwZWF0IDp0 YWcgIlZhbHVlcyIKKyAgICAgICAgICAgICAgICAgKHN0cmluZyA6dGFnICJUZXh0IikpCisg ICAgICAgICAocGxpc3QgIDp0YWcgIlRleHQgcHJvcGVydGllcyIpKSkKKworKGRlZmNvbnN0 IGN1c3RvbS1pY29uLS10eXBlCisgIGAocmVwZWF0IDpmb3JtYXQgLChjb25jYXQgIiV7JXQl fSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAocHJvcGVydGl6ZSAiOiIgJ2Rpc3Bs YXkgIiIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlxuXG4ldiVpXG4iKQorICAg ICAgICAgICA6dGFnICJJY29uIGVsZW1lbnRzOgorLSBPbmx5IHRoZSBmaXJzdCBvY2N1cnJl bmNlIG9mIGEgc2FtZSBlbGVtZW50IGNvdW50cy4KKy0gTWlzc2luZyBlbGVtZW50cyB3aWxs IHRha2UgdGhlaXIgZGVmYXVsdCB2YWx1ZS4KKy0gQXQgbGVhc3Qgb25lIGVsZW1lbnQgc2hv dWxkIGJlIHByb3ZpZGVkIHdpdGggYSB2YWxpZCB2YWx1ZS4iCisgICAgKGNob2ljZSA6dm9p ZCAsY3VzdG9tLWljb24tLXRleHRzLXN1Yi10eXBlCisgICAgICAgICAgICA6ZXh0cmEtb2Zm c2V0IC0zCisgICAgICAgICAgICAsY3VzdG9tLWljb24tLWltYWdlcy1zdWItdHlwZQorICAg ICAgICAgICAgLGN1c3RvbS1pY29uLS1lbW9qaXMtc3ViLXR5cGUKKyAgICAgICAgICAgICxj dXN0b20taWNvbi0tc3ltYm9scy1zdWItdHlwZQorICAgICAgICAgICAgLGN1c3RvbS1pY29u LS10ZXh0cy1zdWItdHlwZSkpKQorCiAoZGVmdW4gY3VzdG9tLWljb24tdmFsdWUtY3JlYXRl ICh3aWRnZXQpCiAgICJIZXJlIGlzIHdoZXJlIHlvdSBlZGl0IHRoZSBpY29uJ3Mgc3BlY2lm aWNhdGlvbi4iCiAgIChjdXN0b20tbG9hZC13aWRnZXQgd2lkZ2V0KQpAQCAtNTUzNSwxMyAr NTU4Miw3IEBAIGN1c3RvbS1pY29uLXZhbHVlLWNyZWF0ZQogCSAoZm9ybSAod2lkZ2V0LWdl dCB3aWRnZXQgOmN1c3RvbS1mb3JtKSkKIAkgKHN5bWJvbCAod2lkZ2V0LWdldCB3aWRnZXQg OnZhbHVlKSkKIAkgKHRhZyAod2lkZ2V0LWdldCB3aWRnZXQgOnRhZykpCi0JICh0eXBlICco cmVwZWF0Ci0gICAgICAgICAgICAgICAgIChsaXN0IChjaG9pY2UgKGNvbnN0IDp0YWcgIklt YWdlcyIgaW1hZ2UpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGNvbnN0IDp0 YWcgIkNvbG9yZnVsIEVtb2ppcyIgZW1vamkpCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKGNvbnN0IDp0YWcgIk1vbm9jaHJvbWUgU3ltYm9scyIgc3ltYm9sKQotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChjb25zdCA6dGFnICJUZXh0IE9ubHkiIHRleHQp KQotICAgICAgICAgICAgICAgICAgICAgICAocmVwZWF0IHN0cmluZykKLSAgICAgICAgICAg ICAgICAgICAgICAgcGxpc3QpKSkKKwkgKHR5cGUgY3VzdG9tLWljb24tLXR5cGUpCiAJIChw cmVmaXggKHdpZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tcHJlZml4KSkKIAkgKGxhc3QgKHdp ZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tbGFzdCkpCiAJIChzdHlsZSAod2lkZ2V0LWdldCB3 aWRnZXQgOmN1c3RvbS1zdHlsZSkpCg== --------------2v1xAl04xulOinUXJ106pOFF--