From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com
Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase
Date: Fri, 10 Jun 2022 09:44:41 -0700 [thread overview]
Message-ID: <820ec35d-6f93-e0ad-1b07-f07339da8360@gmail.com> (raw)
In-Reply-To: <83leu4zf1u.fsf@gnu.org>
On 6/10/2022 8:58 AM, Eli Zaretskii wrote:
>> Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com
>> From: Jim Porter <jporterbugs@gmail.com>
>> Date: Fri, 10 Jun 2022 08:44:22 -0700
>>
>> On 6/9/2022 10:52 PM, Eli Zaretskii wrote:
>>> What if there's an external command named 'listify' -- is there any
>>> chance that the test will invoke it? If so, I think we should come up
>>> with a safer solution.
>>
>> No, that shouldn't be a problem. When Eshell executes something that
>> looks like a shell command[1], the order of precedence is this:
>>
>> 1. If an alias for the command exists in .emacs.d/eshell/aliases, use
>> that. (This won't happen in tests, since `eshell-test-command-result'
>> binds `eshell-directory-name' to a temp dir.)
>>
>> 2. If there's a Lisp function named `eshell/COMMAND', use that.
>>
>> 3. If there's an external command named `COMMAND', use that.
>>
>> 4. If there's a Lisp function named `COMMAND', use that.
>
> So the problem with using 'list' was that there was no Lisp function
> eshell/list, is that right?
Correct. I think `listify' (aka `eshell/listify') is the preferred
Eshell way of expressing that for the command-style syntax.
Maybe an `eshell/list' function would be good to have, but I'm not sure
this problem would come up outside of the unit tests. They're really
just trying to exercise all the different ways to expand variables, so
the actual commands aren't very practical.
prev parent reply other threads:[~2022-06-10 16:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 3:43 bug#55696: 28.1; eshell fails to respect text-scale-increase Jeff Kowalski
2022-06-03 4:41 ` Jim Porter
2022-06-03 6:31 ` Eli Zaretskii
2022-06-03 20:30 ` Jim Porter
2022-06-04 6:20 ` Eli Zaretskii
2022-06-05 4:49 ` Jim Porter
2022-06-05 9:13 ` Eli Zaretskii
2022-06-05 18:12 ` Jim Porter
2022-06-05 19:00 ` Eli Zaretskii
2022-06-05 19:59 ` Jim Porter
2022-06-06 12:43 ` Eli Zaretskii
2022-06-07 3:04 ` Jim Porter
2022-06-07 10:55 ` Eli Zaretskii
2022-06-08 8:07 ` martin rudalics
2022-06-08 23:20 ` Jim Porter
2022-06-09 7:24 ` Eli Zaretskii
2022-06-09 15:55 ` Jim Porter
2022-06-09 16:48 ` Eli Zaretskii
2022-06-09 22:14 ` Jim Porter
2022-06-10 5:52 ` Eli Zaretskii
2022-06-10 15:44 ` Jim Porter
2022-06-10 15:58 ` Eli Zaretskii
2022-06-10 16:44 ` Jim Porter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=820ec35d-6f93-e0ad-1b07-f07339da8360@gmail.com \
--to=jporterbugs@gmail.com \
--cc=55696@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jeff.kowalski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).