From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#1077: 23.0.60; x-create-frame: (wrong-type-argument number-or-marker-p nil) Date: Tue, 30 Nov 2010 07:56:55 -0800 Message-ID: <820DF2B77AA64BEA96FCB4091B38D281@us.oracle.com> References: <003e01c9257c$a385d800$0200a8c0@us.oracle.com> <009701c9263f$9cce7120$0200a8c0@us.oracle.com> <000001c94cc1$e10e9c40$0200a8c0@us.oracle.com> <8F1F8998D60341099C4204B7BDD8AD4F@us.oracle.com> <96BC00F728B94AC18A15EA95B66C5248@us.oracle.com> <83zksv5g7j.fsf@gnu.org> <0A475933984F4CDA855D91C8B7639E3B@us.oracle.com> <83fwum5xzk.fsf@gnu.org> <9F24875655894485A414CD785D95725B@us.oracle.com> <83ipzh9qze.fsf@gnu.org> <4CF386C9.5070909@gmx.at> <8362vg9ctt.fsf@gnu.org> <4CF409A3.1030906@gmx.at> <83y68b96c5.fsf@gnu.org> <71C125BECEDF4C5E9F703E5743F76893@us.oracle.com> <83r5e38nhg.fsf@gnu.org> <4CF4AE39.4050007@gmx.at> <4CF503A5.3030404@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1291182805 17829 80.91.229.12 (1 Dec 2010 05:53:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 1 Dec 2010 05:53:25 +0000 (UTC) Cc: 1077@debbugs.gnu.org To: "'Eli Zaretskii'" , "'martin rudalics'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 01 06:53:20 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PNfd1-0005MI-RT for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Dec 2010 06:53:20 +0100 Original-Received: from localhost ([127.0.0.1]:39472 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNfd1-0003mg-Ap for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Dec 2010 00:53:19 -0500 Original-Received: from [140.186.70.92] (port=56700 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNeEv-00035O-O2 for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2010 23:24:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNSr7-0007JK-BU for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2010 11:15:02 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNSr7-0007Id-9Q for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2010 11:15:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PNSUr-0006zG-TB; Tue, 30 Nov 2010 10:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Nov 2010 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 1077 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 1077-submit@debbugs.gnu.org id=B1077.129113229826826 (code B ref 1077); Tue, 30 Nov 2010 15:52:01 +0000 Original-Received: (at 1077) by debbugs.gnu.org; 30 Nov 2010 15:51:38 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNSUT-0006yb-88 for submit@debbugs.gnu.org; Tue, 30 Nov 2010 10:51:37 -0500 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PNSUQ-0006yP-QJ for 1077@debbugs.gnu.org; Tue, 30 Nov 2010 10:51:35 -0500 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oAUFv9PJ003050 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 30 Nov 2010 15:57:10 GMT Original-Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oAU28TMe014811; Tue, 30 Nov 2010 15:57:07 GMT Original-Received: from abhmt001.oracle.com by acsmt353.oracle.com with ESMTP id 826762231291132617; Tue, 30 Nov 2010 07:56:57 -0800 Original-Received: from dradamslap1 (/10.159.217.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 30 Nov 2010 07:56:56 -0800 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcuQoOYct/QdxQ5MQgS4nAmz8jRPyAABHgRA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 30 Nov 2010 10:52:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42021 Archived-At: > > But if not entry for `menu-bar-lines' exists, calling > > (frame-parameter ... 'menu-bar-lines) returns nil. > > That's not guaranteed to be true. You will see in the implementation > of frame-parameter and frame-parameters that we return values for some > frame parameters without ever looking at the frame's parameter alist. > It's true that frame-parameter actually does look in frame's parameter > alist when the value of menu-bar-lines is requested, but > frame-parameters does not, at least for TTYs. My impression (I don't have references to prove it) is that this general rule _has_ worked, and it has only recently (in the last few years) been broken. And IIRC it was broken by Emacs Dev when trying to work around (fix) bugs introduced wrt the tool-bar code. IOW, my impression is that we ended up breaking this behavior because that's how we decided to fix some bugs that were introduced. This stuff (e.g. tool-bar code) became more complex during this process, especially in conjunction with startup and the default frame alists. Overall, the tool-bar behavior might have been improved (dunno), but I'm not sure the general handling of frame parameters didn't suffer. Yidong might have something different to say about this. My impression is only that, an impression. I believe he is familiar with the code and the changes. > That said, I agree that any code which is called during frame creation > should be able to avoid signaling an error. I think a frame alist entry of `(menu-bar-lines)' should be handled correctly: handled just the same as `(menu-bar-lines . 0)' and the same as having no entry. > If so, this is a thing of the past, as we no longer need > menu-bar-mode, menu-bar-lines alone is enough, right? I'm not aware that there ever was a _frame parameter_ named `menu-bar-mode'. Certainly there is none mentioned in the Emacs 20 Elisp manual. There is a `menu-bar-mode' _command_ (and mode). > Even funnier, the ELisp manual shows an example of building a menu bar > with two lines, see the node "Menu Bar" there. And that should be possible. If it isn't possible today because of some limitations then it should be kept as a future possibility and put on the TODO list (IMO).