From: Jim Porter <jporterbugs@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>, 71576@debbugs.gnu.org
Subject: bug#71576: 30.0.50; [PATCH] Improve performance of Comint/Eshell password prompt handling
Date: Sun, 16 Jun 2024 18:18:01 -0700 [thread overview]
Message-ID: <81f2ba94-65a3-7c20-5f73-4d898713eb7f@gmail.com> (raw)
In-Reply-To: <CADwFkm=TvsKTmKH4Fyt0S7g-a0C88wd2+jekBQ+jCXY11WnqoQ@mail.gmail.com>
On 6/16/2024 3:53 AM, Stefan Kangas wrote:
> Thanks. I'd be okay with putting this patch in Emacs 30, but let's see
> what other people think.
Sounds good to me.
>> +(defcustom comint-password-prompt-max-length 256
>> + "The maximum amount of text to examine when matching password prompts.
>> +When non-nil, only examine the last N characters of a block of output.
>> +If nil, examine all the output.
>> +
>> +This is used by `comint-watch-for-password-prompt' to reduce the amount
>> +of time spent searching for password prompts."
>> + :version "30.1"
>> + :type '(choice natnum
>> + (const :tag "Examine all output" nil))
>> + :group 'comint)
>
> If this is hardcoded in Tramp, are we sure that we need this as an
> option? I'd suggest making it into a defconst or defvar instead.
I don't have a strong opinion here, so I'll wait to see if a majority
forms around this...
>> + (goto-char (if eshell-password-prompt-max-length
>> + (max eshell-last-output-block-begin
>> + (- eshell-last-output-end
>> + eshell-password-prompt-max-length))
>> + eshell-last-output-block-begin))
>> + (when (let ((case-fold-search t))
>> + (re-search-forward eshell-password-prompt-regexp
>> + eshell-last-output-end t))
>
> Could this be simplified using re-search-backward with the BOUND
> argument instead?
I tried, but since I think most of this logic is necessary, it just
amounted to swapping the 'if' block with 'eshell-last-output-end'.
Performance doesn't look any different, and I find the current way a bit
more readable.
(This could probably be simplified if we want to require that
'eshell-password-prompt-max-length' be non-nil though.)
next prev parent reply other threads:[~2024-06-17 1:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-15 19:50 bug#71576: 30.0.50; [PATCH] Improve performance of Comint/Eshell password prompt handling Jim Porter
2024-06-16 7:45 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-16 10:53 ` Stefan Kangas
2024-06-16 12:29 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-17 1:18 ` Jim Porter [this message]
2024-06-21 0:42 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81f2ba94-65a3-7c20-5f73-4d898713eb7f@gmail.com \
--to=jporterbugs@gmail.com \
--cc=71576@debbugs.gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).