From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.bugs Subject: bug#9480: 24.0.50; (vc-git) stash@{n} - requires shell quoting? Date: Mon, 12 Sep 2011 14:35:48 +0530 Message-ID: <81d3f6t9jn.fsf@gmail.com> References: <81sjo2fd8o.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1315818414 27382 80.91.229.12 (12 Sep 2011 09:06:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 12 Sep 2011 09:06:54 +0000 (UTC) Cc: 9480@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 12 11:06:47 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R32TW-0000MC-UE for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Sep 2011 11:06:47 +0200 Original-Received: from localhost ([::1]:55225 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R32TW-0002Jd-Ef for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Sep 2011 05:06:46 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:40396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R32TT-0002JQ-UG for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2011 05:06:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R32TS-0003dX-Pq for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2011 05:06:43 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45583) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R32TS-0003dR-Ld for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2011 05:06:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R32Xe-0005YI-IL; Mon, 12 Sep 2011 05:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Sep 2011 09:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9480 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9480-submit@debbugs.gnu.org id=B9480.131581863121305 (code B ref 9480); Mon, 12 Sep 2011 09:11:02 +0000 Original-Received: (at 9480) by debbugs.gnu.org; 12 Sep 2011 09:10:31 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R32X8-0005Xa-N5 for submit@debbugs.gnu.org; Mon, 12 Sep 2011 05:10:30 -0400 Original-Received: from mail-pz0-f47.google.com ([209.85.210.47]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R32X6-0005XS-4t for 9480@debbugs.gnu.org; Mon, 12 Sep 2011 05:10:29 -0400 Original-Received: by pzk2 with SMTP id 2so5374060pzk.20 for <9480@debbugs.gnu.org>; Mon, 12 Sep 2011 02:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=8XuE/5YSySFxF4iKi339npdlyBjEVsKUtUw3AmVJi0E=; b=T6Gwp3Mp0atZUtZnJ2mVWTqlMyAm1SEK1dritCA5rE3AJYc5XWPV+m/Duuia1q1SkC QStrJ59taOmxSuuXSpBpopR2vNaprJC5+4m9bk7TzNYWqjM5d7ljC0+GljiUQpDJMMZM wSmk2DoJCEmnxVZgLlmtrsBYQFQdxjDaqSpcQ= Original-Received: by 10.68.199.233 with SMTP id jn9mr9208pbc.102.1315818366818; Mon, 12 Sep 2011 02:06:06 -0700 (PDT) Original-Received: from JAMBU-NETBOOK ([115.184.17.197]) by mx.google.com with ESMTPS id f6sm6849293pbp.2.2011.09.12.02.06.01 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 12 Sep 2011 02:06:05 -0700 (PDT) In-Reply-To: (Eli Zaretskii's message of "Mon, 12 Sep 2011 03:29:18 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (windows-nt) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 12 Sep 2011 05:11:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51050 Archived-At: Eli Zaretskii writes: >> From: Jambunathan K >> Date: Mon, 12 Sep 2011 12:39:43 +0530 >> >> While in a *vc-dir* buffer (backed by git) and trying to show or apply a >> stash fails. >> >> I am attaching "works for me" patch that shell-quotes stash@{n} >> argument. With this "patch", the stash commands work as expected. >> >> My shell-file-name is set to "bash" (cygwin version). My Emacs is >> >> In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) > > Can you tell what does git see as its arguments without the quoting? > I would like to establish whether this is some bug specific to the > Windows build of Emacs, since other systems that use Bash evidently > don't need this change. With the failing setup and (setq vc-command-messages t) I see the following in the *Messages* buffer and it seems OK to me ,---- *Messages* | Running git update-index --refresh . in background... done | Running git diff-index --relative -z -M HEAD -- . in background... done | Running git ls-files -z -o --directory --no-empty-directory --exclude-standard -- . in background... done | Running git stash show -p stash@{0} . in background... done `---- But in the *vc-git-stash* buffer I see the following message ,---- *vc-git-stash* | '-p stash@0' is not a stash `---- Not the absence of `{' `}' in the error report. I hope that provides some clue on what the underlying git sees. With my "works for me" changes, I see the following ,---- *Messages* | Running git stash show -p stash\@\{0\} . in background... done `---- ,---- *vc-git-stash* | diff --git a/contrib/lisp/org-odt.el b/contrib/lisp/org-odt.el | index 5bc73a7..91c98ea 100644 | --- a/contrib/lisp/org-odt.el | +++ b/contrib/lisp/org-odt.el | @@ -636,7 +636,28 @@ PUB-DIR is set, use this as the publishing directory." | (defvar org-lparse-table-is-styled) | (defvar org-lparse-table-rowgrp-info) | (defvar org-lparse-table-colalign-vector) | + | [snip] `---- Let me know if you need more information. FWIW, git is also from cygwin installation. Jambunathan K.