From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 22457@debbugs.gnu.org
Subject: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes
Date: Tue, 25 Jun 2019 09:06:46 -0700 (PDT) [thread overview]
Message-ID: <81cf46a6-c57a-4f90-a203-7e963b232f6a@default> (raw)
In-Reply-To: <m3d0j1651p.fsf@gnus.org>
> And why is dired-mark-if a macro in the first place? It's pretty long
> to be a macro; it could be rewritten as a function that take a
> predicate...
(Length of a macro's code makes no difference, if
the code using it is compiled.)
I would say leave this sleeping dog lie...
---
The PREDICATE arg is really code (a sexp), not
a predicate (function).
See also the use of `dired-mark-if' in command
`dired-mark-sexp' (in `dired-x.el'). See the
doc string of that command.
There too the PREDICATE arg is code (a sexp),
not a predicate. And there you can use a set
of predefined variables in the "PREDICATE"
sexp that gets evaluated and then passed to
`dired-mark-if'.
See also the uses of `dired-mark-if' in
`dired-aux.el', where an anonymous function
is constructed using the macro.
This is the way things have been since about
Day One of Emacs.
Could things have been coded differently for
this? Likely. Should they be? Doubtful.
prev parent reply other threads:[~2019-06-25 16:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 18:05 bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes Drew Adams
2019-06-25 14:42 ` Lars Ingebrigtsen
2019-06-25 15:33 ` Drew Adams
2019-06-25 15:44 ` Lars Ingebrigtsen
2019-06-25 22:47 ` Michael Heerdegen
2019-06-25 22:53 ` Lars Ingebrigtsen
2019-06-25 23:02 ` Michael Heerdegen
2019-06-25 23:12 ` Lars Ingebrigtsen
2019-06-25 23:26 ` Drew Adams
2019-06-25 23:30 ` Michael Heerdegen
2019-06-26 0:00 ` Drew Adams
2019-06-26 8:50 ` Andreas Schwab
2019-06-26 13:32 ` Drew Adams
2019-06-25 23:17 ` Drew Adams
2019-06-25 23:28 ` Michael Heerdegen
2019-06-25 15:46 ` Lars Ingebrigtsen
2019-06-25 16:06 ` Drew Adams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81cf46a6-c57a-4f90-a203-7e963b232f6a@default \
--to=drew.adams@oracle.com \
--cc=22457@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).