From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#3984: 23.0.96; defadvice of call-interactively defeats interactive-p Date: Fri, 31 Jul 2009 13:04:04 -0700 Message-ID: <81D9B59304B04F3DBF3ADD2C3595A824@us.oracle.com> References: <20E00C7675E64356BF2F0B2A7E0ABDB1@us.oracle.com><2707E3CF212E4D7B801D2F2EEAF54373@us.oracle.com> Reply-To: Drew Adams , 3984@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1249072323 29896 80.91.229.12 (31 Jul 2009 20:32:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Jul 2009 20:32:03 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, 3984@emacsbugs.donarmstrong.com To: "'Stefan Monnier'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 31 22:31:56 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MWylf-0006qy-FH for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Jul 2009 22:31:55 +0200 Original-Received: from localhost ([127.0.0.1]:38949 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWyle-0003EL-LZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Jul 2009 16:31:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MWygn-0006fg-E2 for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 16:26:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MWygi-0006Zt-Gi for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 16:26:53 -0400 Original-Received: from [199.232.76.173] (port=42786 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MWygi-0006ZV-9a for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 16:26:48 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:52289) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MWygh-0003i5-KU for bug-gnu-emacs@gnu.org; Fri, 31 Jul 2009 16:26:48 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6VKQj3I020634; Fri, 31 Jul 2009 13:26:45 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n6VKA8ft019316; Fri, 31 Jul 2009 13:10:08 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 31 Jul 2009 20:10:08 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3984 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3984-submit@emacsbugs.donarmstrong.com id=B3984.124907065818050 (code B ref 3984); Fri, 31 Jul 2009 20:10:08 +0000 Original-Received: (at 3984) by emacsbugs.donarmstrong.com; 31 Jul 2009 20:04:18 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6VK4ElA018045 for <3984@emacsbugs.donarmstrong.com>; Fri, 31 Jul 2009 13:04:15 -0700 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n6VK46tv002576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 31 Jul 2009 20:04:07 GMT Original-Received: from abhmt008.oracle.com (abhmt008.oracle.com [141.146.116.17]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n6VK4NQR021380; Fri, 31 Jul 2009 20:04:23 GMT Original-Received: from dradamslap1 (/141.144.98.141) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 31 Jul 2009 13:04:04 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcoSFalzf5O1HVwlSVCKBDKvow+4UwAA4qBA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt008.oracle.com [141.146.116.17] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010207.4A734E35.00B2:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Fri, 31 Jul 2009 16:26:52 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:29773 gmane.emacs.pretest.bugs:24900 Archived-At: > > Is there no way the Emacs implementation could be fixed to > > handle this better? Couldn't it take into consideration > > the `ad-*' stuff that results from advising > > `call-interactively'? IOW, couldn't it look for > > `call-interactively' in its advised form also? > > There's probably some way to make it work, of course. Note that the > same problem is likely to appear with other redefinitions of > call-interactively (e.g. profiling, tracing, ...). Yes. > Of course, another way to break these things is also to advise (and/or > profile/trace/...) interactive-p. Yes. Seems like there could be a list of such functions to check wrt advised (and profiled, etc.) forms. The particular advice wouldn't matter, I believe; I imagine that all that happens is that the function is currently checked. Couldn't the check simply be membership in a list that includes the advised names? Perhaps even have that as the value of a variable, which could be configured (at least by Emacs dev, if not users). Realistically, what do you think is the chance of at least the bug as reported being fixed, that is, at least for advised `call-interactively'? I added a feature to Icicles that I will likely need to remove if `interactive-p' is not made to behave normally. Thx.