unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
	Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: 17446@debbugs.gnu.org
Subject: bug#17446: 24.4.50; What is the situation around `called-interactively-p'?
Date: Fri, 9 May 2014 07:28:13 -0700 (PDT)	[thread overview]
Message-ID: <819a6ab8-db8e-4176-a778-02218f08e7af@default> (raw)
In-Reply-To: <jwvvbtfcadh.fsf-monnier+emacsbugs@gnu.org>

> > So what to do actually to fix such issues ?
> 
> Use an additional argument (you can call it `interactive'),
> provided by the `interactive' spec?
> 
> > Do you plan to make something better around the terrible
> > `called-interactively-p' ?
> 
> We have that already: the extra arg, as suggested in C-h
> f called-interactively-p.

Sure, we already do that.  But that doesn't help when you define
a "command similar to `repeat-complex-command'", as Thierry says,
and as I have done too.  Such a command has little control over
the definition of the command that it invokes.

> > That's ok, but what to do when nothing else is possible ?
> 
> AFAIK something else is always possible and preferable.  But I don't
> know enough about your problem to know that it's indeed also the case in
> your situation.

I thought he described it pretty well.  Write a command that is
similar to `repeat-complex-command'.  Now make it work-around Emacs
bug #14136.

You end up doing for your new command something like what Emacs
does for `repeat-complex-command'.  And AFAICT, that works only
when the helper function (similar to vanilla Emacs function
`repeat-complex-command--called-interactively-skip') is
byte-compiled.






  reply	other threads:[~2014-05-09 14:28 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 12:29 bug#17446: 24.4.50; What is the situation around `called-interactively-p'? Thierry Volpiatto
2014-05-09 13:39 ` Drew Adams
2014-05-09 14:11   ` Michael Heerdegen
2014-05-09 14:47     ` Drew Adams
2014-05-09 14:17   ` Drew Adams
2014-05-09 14:15 ` Stefan Monnier
2014-05-09 14:28   ` Drew Adams [this message]
2014-05-09 14:50     ` Stefan Monnier
2014-05-09 14:55       ` Drew Adams
2014-05-09 15:15         ` Michael Heerdegen
2014-05-09 17:53           ` Stefan Monnier
2014-05-09 18:47             ` Thierry Volpiatto
2014-05-09 19:50               ` Stefan Monnier
2014-05-09 21:02                 ` Stefan Monnier
2014-05-09 22:39                   ` Stefan Monnier
2014-05-09 23:34                     ` Drew Adams
2014-05-10  2:13                       ` Stefan Monnier
2014-05-10  9:10                       ` Thierry Volpiatto
2014-05-10  6:12                     ` Thierry Volpiatto
2014-05-10  7:40                     ` Michael Heerdegen
2014-05-10  8:41                       ` Thierry Volpiatto
2014-05-10  5:51                   ` Thierry Volpiatto
2014-05-10  6:45                     ` Stefan Monnier
2014-05-10  8:06                       ` Thierry Volpiatto
2014-05-10 20:15                         ` Stefan Monnier
2014-05-11  4:24                           ` Michael Heerdegen
2014-05-11  5:58                             ` Michael Heerdegen
2014-05-17 18:01                               ` Michael Heerdegen
2014-05-18  1:56                                 ` Stefan Monnier
2014-05-11  6:02                             ` Stefan Monnier
2014-05-11  4:31                           ` Thierry Volpiatto
2014-05-10 10:22                       ` Andreas Röhler
2014-05-10 20:19                         ` Stefan Monnier
2014-05-11  7:47                           ` Andreas Röhler
2014-05-10  3:43                 ` Thierry Volpiatto
2017-03-25  6:23                 ` npostavs
2014-05-09 19:16             ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=819a6ab8-db8e-4176-a778-02218f08e7af@default \
    --to=drew.adams@oracle.com \
    --cc=17446@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=thierry.volpiatto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).