From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized Date: Thu, 10 Sep 2020 09:16:01 +0200 Message-ID: <818f2053-a996-7ade-c1cf-6592b6d2cde5@gmx.at> References: <5889C6B4.8060506@gmx.at> <588A0102.7010704@gmx.at> <588B108E.9070501@gmx.at> <588B1437.9010303@gmx.at> <588B4F7C.40909@gmx.at> <588C5003.4070409@gmx.at> <87r1rhbu2s.fsf@gnus.org> <83wo18pvoh.fsf@gnu.org> <17a425a3-7b6e-56bc-40a3-35ac78fdaa6a@gmx.at> <56ee5ed9-fd85-b5c3-6aba-d51332398f03@cornell.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35624"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Magne Ingebrigtsen , 25542@debbugs.gnu.org, Noam Postavsky To: Ken Brown , Dani Moncayo , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 10 09:17:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGGpn-00098B-ND for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 09:17:31 +0200 Original-Received: from localhost ([::1]:57588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGGpm-0004sj-CX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Sep 2020 03:17:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGGpL-0004sX-2F for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 03:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52536) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGGpK-0003UN-Jk for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 03:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGGpK-0002xl-7R for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2020 03:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Sep 2020 07:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25542 X-GNU-PR-Package: emacs Original-Received: via spool by 25542-submit@debbugs.gnu.org id=B25542.159972218911342 (code B ref 25542); Thu, 10 Sep 2020 07:17:02 +0000 Original-Received: (at 25542) by debbugs.gnu.org; 10 Sep 2020 07:16:29 +0000 Original-Received: from localhost ([127.0.0.1]:35849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGGom-0002ws-Od for submit@debbugs.gnu.org; Thu, 10 Sep 2020 03:16:28 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:42447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGGoi-0002wd-2J for 25542@debbugs.gnu.org; Thu, 10 Sep 2020 03:16:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599722163; bh=st5Kbr6fshx6SjtxgtzsPa1iGT/10AmUyjTjqWj8I0Y=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=fmTxhinQmzW+Xo/+Hv9Av4T715abDJR/x7/sDEsb8oM8j/lJGAAdqZRGkJ4VUrgld B9ZN9CL0o/ikuafxiAv2jZnZ4LSdMju/FTPbLOzQrdoE5yKUesdN7YrcQnlQOBBdZ2 qITUKYKlnux4ipnByhKV++Zd8mp8GC2pIlrt0Il4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([212.95.5.97]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M4s0j-1kHeFw0PRP-002292; Thu, 10 Sep 2020 09:16:03 +0200 In-Reply-To: <56ee5ed9-fd85-b5c3-6aba-d51332398f03@cornell.edu> Content-Language: en-US X-Provags-ID: V03:K1:/+rjaCEtH/8DC1NcwS7oSr5wfDdYqrdTUHoTMDuSh642PlnTsvY YIWc+J/XNf4Hlk7EopuPWKg89Thjk8WoLTi1TmULZt49nPVPixOAV3sw2+KgyioMrkWv2W6 nsHVE9Kn1Eh3CwEV4KPEmi0U4fP0jzYvvajori45I/R1e0ruwccv3nSW8oWBAexv9XQ8yYK 0yYtys1ayW3tmNfb006EA== X-UI-Out-Filterresults: notjunk:1;V03:K0:/URKmN4ijDw=:Unkde5WBvD3Fec8wFwSVel wMKCb+LNbmNoOsCCkufoD3M5jU8h4P39hVLhIDGH3eTkrhP+Y27hQU/z1B8t6zG9ZXmjT8C7F X0V+7bvl761tbEzARdzfQe3fqgHW2QSScsCaV4v4FbGnO1oJ12aMrbhe4Z6Wz3do2BW8wkBRP MN5BPYWp9OUQyVsRcLj5vWALDKkwsKHz1wkpSuK9D8OQNVIDWLfnr2UM2dhmLZhpcHaoZkMFo nwdWjtoZOdHBKkFMlLXUq7usDP4DOLhmosHNeOH0SWEZFMAbRMIo9XItjy76l1E+j9DV2hgmr /RdVeZDiMoIdXaK8A3wA1+THkOU8eytDL0nhyyL5SRqJFdiUO0Ccu/wnbDerw60kUF6PvuRmT VZ9s5J56av4Nm3Sk/u1HdHBc+FweSYPDa6kuQjpgqCzK5suw/B+TMoSwAGOuGJk/M81Pf4QCG s0VljPo7nkV4/Pnsf0g5lLL/8OM4gJq8LOo174QUkR5BpFhwjMxPKSEApPyVQZMobNELe0tip msrXw8hP6WCAHYEx12BRpgfjbHBIpsvPSBiCRj0pb0p9fEkvOEZmcpBpqaqPdX2OCqUcEkGj7 VlGcbYn3TG/iomKteDYRdJ7/PDS89128FCdtasordwvzJ0C2014WT3cBP7W1uxzCnrEmfcJJp urJnC470CnOvTWwv2Hpah8vt4TQpjBXjJLYij0H1hjSqvcg76WMu25NhM8vq7tLh/gLfS9PYz bfUYMcefhBWx/LgXwPsV0mqFcSZR5mbfs6J9ddEjM+ZFDYqWyCJVfdwXxnW/xVLmyq/zB3wl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187719 Archived-At: >> I just tried this on a Cygwin-w32 build from the master branch. I put the taskbar on the left, started emacs, maximized it, attached gdb, put breakpoints at each of the ShowWindow lines, and ran through Dani's recipe for producing the bug. The breakpoints were never hit. > > I just tried again, but this time with a breakpoint at w32fullscreen_hook so that I could follow the flow. Here are the relevant excerpts from the gdb session: Thank you very much for checking. > Breakpoint 2 at 0x10069507a: file ../../master/src/w32term.c, line 6441. > (gdb) r -Q > Starting program: /home/kbrown/src/emacs/x86_64-w32/src/emacs -Q > > [...] > > [Press F11] > > Thread 1 "emacs" hit Breakpoint 2, w32fullscreen_hook (f=0x8001f7c88) > at ../../master/src/w32term.c:6441 [...] > 6464 FRAME_PREV_FSMODE (f) = f->want_fullscreen; > (gdb) p f->want_fullscreen > $1 = FULLSCREEN_BOTH While this is the expected value ... > [...] > > (gdb) c > Continuing. > > [Press F11 again] > > Thread 1 "emacs" hit Breakpoint 2, w32fullscreen_hook (f=0x8001f7c88) > at ../../master/src/w32term.c:6441 [...] > 6451 if (FRAME_PREV_FSMODE (f) == FULLSCREEN_NONE) > (gdb) p f->want_fullscreen > $2 = FULLSCREEN_NONE ... the value I would have expected here is FULLSCREEN_MAXIMIZED. Something must have got broken before. Can you please (1) Verify that the f->want_fullscreen &= ~FULLSCREEN_WAIT; does not interfere in any respect. That is, does f->want_fullscreen have the same value FULLSCREEN_NONE before anding it with FULLSCREEN_WAIT? (2) Does 'toggle-frame-fullscreen' the second time when you type F11 correctly call (set-frame-parameter frame 'fullscreen fullscreen-restore) with 'fullscreen-restore' equal to 'maximized' at all? (3) Verify that calling w32fullscreen_hook with the taskbar on the bottom does hit the breakpoints and subsequently maximize the frame as expected. Thanks again, martin