From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now Date: Fri, 27 Dec 2013 16:55:11 -0800 (PST) Message-ID: <818df3a7-a5fa-4871-86e1-0bd5d8e4a5fc@default> References: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1388192179 14195 80.91.229.3 (28 Dec 2013 00:56:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Dec 2013 00:56:19 +0000 (UTC) Cc: 16251-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 28 01:56:23 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VwiCU-0007Pz-Q7 for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Dec 2013 01:56:23 +0100 Original-Received: from localhost ([::1]:50811 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwiCU-0005Kd-CD for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Dec 2013 19:56:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwiCJ-0005Jf-9e for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2013 19:56:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VwiCA-0002VS-LR for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2013 19:56:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwiCA-0002VO-Ii for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2013 19:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VwiCA-0003u3-2u for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2013 19:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Dec 2013 00:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16251 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16251-done@debbugs.gnu.org id=D16251.138819212314937 (code D ref 16251); Sat, 28 Dec 2013 00:56:02 +0000 Original-Received: (at 16251-done) by debbugs.gnu.org; 28 Dec 2013 00:55:23 +0000 Original-Received: from localhost ([127.0.0.1]:47394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwiBW-0003sq-GJ for submit@debbugs.gnu.org; Fri, 27 Dec 2013 19:55:22 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:42199) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwiBS-0003sb-V2 for 16251-done@debbugs.gnu.org; Fri, 27 Dec 2013 19:55:19 -0500 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBS0tGTp006315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 28 Dec 2013 00:55:17 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBS0tFro019743 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 28 Dec 2013 00:55:16 GMT Original-Received: from ubhmt101.oracle.com (ubhmt101.oracle.com [156.151.24.6]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBS0tFCW018186; Sat, 28 Dec 2013 00:55:15 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82670 Archived-At: > > I downloaded this build, and when `icomplete-mode' is on, with my > > setup it takes several seconds to gather the list of file candidates > > in my usual directory. This was my bad. I was passing this to `cl-delete-if': (regexp-opt completion-ignored-extensions). Taking that calculation out of the loop saved 13 seconds! (99% of the total time). FWIW, here are some times (now) of various parts (with my code, with my find-file replacement, in my typical startup directory, about 2400 files): completion-all-completions: 680 ms deleting duplicates: 70 ms sorting: 470 ms Of course, sorting depends on the sort predicate. This was with a directories-first-then-alphabetical sort. > I just reverted icomplete-show-matches-on-no-input to nil, which > I think is the right default. Thx. > That it can take a long time to get the completions is not in itself > a bug. There are 2 potential bugs left, tho: > > - hitting a key should interrupt the completions processing (so that > the long wait should not prevent you from getting work done). > If it doesn't, then we have a bug. Please report it separately, with > as much details as possible to reproduce it (it's probably a problem > in the C code). That seems to work OK (as before). > - ideally completion should never take that long, so we probably have > a performance bug somewhere. Of course, that might also be in your > local code (.emacs, icicles, ...). See , above. A problem I do notice now (not sure why now) is that sometimes keys that I hit are "lost" instead of appearing in the input. AFAICT, this happens only when Icomplete is on. It can make completing input painful, to say the least. I don't have a handle yet on just what the behavior is or what causes it. Just mentioning it now in case someone happens to notice it also for vanilla Emacs. --- FWIW - One other thing is somewhat unfortunate in my context, so far: When you cycle among completion candidates (Icicles cycling, not Icomplete cycling), or when there is a sole matching candidate, by default Icicles shows info about the current (or the sole) candidate in the (*Completions*) mode line, for N sec. Hitting a key interrupts this, of course - it is done using `sit-for'. But of course `post-command-hook' actions do not take place until that delay is over. This means that icompletions do not show up until the mode-line display is finished. I guess I should instead show the info until some timer gets rid of it, so that it stays visible even when `post-command-hook' is run.