From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#60830: 30.0.50; The *Compilation* buffer does not recognize Lua errors Date: Sun, 8 Oct 2023 11:59:18 +0200 Message-ID: <8170D896-5520-4A5E-83F0-51C99BD54802@gmail.com> References: <909EF5E1-6F30-4A35-84E8-2EF4333115FD@gmail.com> <4996E536-72CE-4E6A-9C75-CF7307A82469@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16099"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60830@debbugs.gnu.org, Stefan Kangas , Stefan Monnier To: Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 08 12:00:03 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpQZv-000405-Jc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Oct 2023 12:00:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpQZl-0005Ux-Fq; Sun, 08 Oct 2023 05:59:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpQZg-0005UZ-JG for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2023 05:59:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpQZd-0005KW-Kl for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2023 05:59:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qpQZu-0007hF-GV for bug-gnu-emacs@gnu.org; Sun, 08 Oct 2023 06:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Oct 2023 10:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60830 X-GNU-PR-Package: emacs Original-Received: via spool by 60830-submit@debbugs.gnu.org id=B60830.169675918929520 (code B ref 60830); Sun, 08 Oct 2023 10:00:02 +0000 Original-Received: (at 60830) by debbugs.gnu.org; 8 Oct 2023 09:59:49 +0000 Original-Received: from localhost ([127.0.0.1]:56287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpQZg-0007g4-II for submit@debbugs.gnu.org; Sun, 08 Oct 2023 05:59:48 -0400 Original-Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:58804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpQZe-0007fh-Lu for 60830@debbugs.gnu.org; Sun, 08 Oct 2023 05:59:47 -0400 Original-Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c3ca6ff5a7so18962951fa.1 for <60830@debbugs.gnu.org>; Sun, 08 Oct 2023 02:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696759161; x=1697363961; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=ZD0pUwH+MqML+nEfpi0y6ZRG4vML4h3bhfI9kQGNGqo=; b=Ck5P8XGQUBBt2m9qUYGdhWFWeIlT7WjniWjJsRL1SJTiEPQPyEPECWDvQ2xkxd987T +EJP9GP6wZka6rCjElfgHMdECgBs3JtMtXkw6NrE2UzK9NPv+xuhZ91Kl3GUMeuf0Ybh wU3CjMLmVANQ7aNREMNeExU8V/dVc17nEz9XWAMrYt3qZWUmuTB+13BhecAo+zzrU1X5 VGOJdzmLVG1U1Bdjphy8U4LHJ9WbjCZ+K5S7OVtFPAvY8LpFWBo5aF+lbSsZb9ClrbZr vSht2UxuR1HwteMyEssCQrVJ2qgGXP9Rp0DJzYr/w3Zn25krfb1MKMgkqVT7aB83rtbX 2ikg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696759161; x=1697363961; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZD0pUwH+MqML+nEfpi0y6ZRG4vML4h3bhfI9kQGNGqo=; b=E+gxaTSMwPvO7KQ4xkkH63OEL3GGww2/xUxU8zj6sWaeV3vZUTXKP/rB4qcDDwA3aF mYr+5f4ohSzF+2vPK6lIq0AWCcwAsk2/xuzS6u+eCDIoCQYsyOdDOH5L0uxBwfBr8MDj Z3+IxcaEV8mMUqoZutgVevP9upRdcNfFx8XN45PYrKs+e+FBvhZfPExSd0UuBoIdSdnR MVQpJe8sEQMVnXOKCV/2MA7qChktWTwejove9GN5fjTqKMMWUr1rzndln57Ci3cMomDB i/K+Ou2r4OAfxOnk95cZHIGpXyIf3PQspqaIF4U8yXErzju7kU2BcTOE9pwu8AC40IUH JIDA== X-Gm-Message-State: AOJu0Yz6DzZPslWw43KX165MurOjkUlivrvVd2Y1ZlZaksE3LLTv+1UY uxK7dy6GxHtYQSEJeVKIMNE= X-Google-Smtp-Source: AGHT+IHXLuhxhHHK4F2eOMT+qVneuYytpvJ1iUCvbHadqJgzB+QrmX88p7cVpqcWbHkRTOdgPiZpcA== X-Received: by 2002:a2e:8eca:0:b0:2bc:39f5:ecb4 with SMTP id e10-20020a2e8eca000000b002bc39f5ecb4mr10765341ljl.25.1696759160386; Sun, 08 Oct 2023 02:59:20 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id r25-20020a2e9959000000b002bfba0d26bcsm1573361ljj.8.2023.10.08.02.59.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Oct 2023 02:59:19 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272070 Archived-At: 7 okt. 2023 kl. 23.02 skrev Rudolf Adamkovi=C4=8D : > (1) How can I specify "this group cannot be '[C]'" in the regexp? Disallow files starting with a left square bracket? > (2) How can I test this scenario in 'compile-tests.el'? We can help out. > I made the relevant groups greedy, but I wonder what difference it > makes. Only use non-greedy operators if they make the regexp significantly = easier to express. Greedy should be the default. Non-greedy operators are usually less efficient, and always raise = eyebrows when read: why is this non-greedy? Writing ".*?\n", as you did, makes no sense at all since "." will match = anything except newline, and the result is identical to ".*\n" but less = readable and maybe slower. >> We try to make rules work with Windows file names (or names = containing >> spaces, which are also somewhat common on Windows) where relevant and >> practical. Your patterns don't; can you argue that it's not useful = for >> Lua or not possible to do so? >=20 > Good catch! Fixed. Maybe you should test it just in case. (You don't need a Windows machine = to do that but it adds authenticity). > I would understand if we did that for some long-dead compilers but not > for Lua. Look, it's not a beauty contest. We'll do what we have to. > We still detect the file path/name, which is useful. The point is that it substantially increases the risks of false matches. = Lua needs to be a good neighbour and can't just think of its own needs = over anything else.