From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#59963: 29.0.50; 'window-max-chars-per-line' doesn't always work on GUI without fringe Date: Mon, 12 Dec 2022 17:50:44 +0100 Message-ID: <807e40b5-41a1-7a1a-52d2-5815399fa7a2@gmx.at> References: <87edt6dwgq.fsf@disroot.org> <83sfhmt30p.fsf@gnu.org> <87o7sac78t.fsf@disroot.org> <87h6y2c6fq.fsf@disroot.org> <83ilihudcr.fsf@gnu.org> <58cc3d32-65f9-d4ad-4668-732af0f3aa36@gmx.at> <83iligsr7r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39394"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59963@debbugs.gnu.org, akib@disroot.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 17:52:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4m2S-0009yQ-9L for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 17:52:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4m1O-0002di-LW; Mon, 12 Dec 2022 11:51:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4m1D-0002S7-Gy for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 11:51:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4m18-0003iq-Dq for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 11:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4m17-0000o5-Vi for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 11:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 16:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59963 X-GNU-PR-Package: emacs Original-Received: via spool by 59963-submit@debbugs.gnu.org id=B59963.16708638583095 (code B ref 59963); Mon, 12 Dec 2022 16:51:01 +0000 Original-Received: (at 59963) by debbugs.gnu.org; 12 Dec 2022 16:50:58 +0000 Original-Received: from localhost ([127.0.0.1]:54055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4m14-0000nr-Gg for submit@debbugs.gnu.org; Mon, 12 Dec 2022 11:50:58 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:50087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4m10-0000ng-Uj for 59963@debbugs.gnu.org; Mon, 12 Dec 2022 11:50:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1670863845; bh=a0a8Ae3GkqdF43wAPmVy8ncHMR59cuYO4j0DA78JpVM=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=ueZFfOm7xv9d6TYCWnGx167lhbf8dzrWqvAiKbuNjXdpPKA6Q1j463qkqmHnLZ3Eo 4lCJNNQcGqrqF0mMlLzFu3/upVbUqrdOAPZwhxGFgYsBpju8dk0ySlYt1GCpBoswyz yHC1yDHl9Rv3xVdSKFyhhbdnHp2Yx3hgiIAFbRMrw/P43Np8WZO+tTfHhwjuYUMB78 e9z8tARlFrwD2mBeGwlQW0bEhnREwky4814KM7puXC/0mC47Aua871ijMIQgmGZ2XS jyTiY7YhQmpb8Kiy4BCWlf6/49ghY9W1EZL+4YJhhKRq/llAAYuzpR35BoJBFmDYoG fFTSrg4izeyYQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.1.100] ([212.95.5.243]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MNsw4-1pK4sf2iue-00OGBR; Mon, 12 Dec 2022 17:50:45 +0100 Content-Language: en-US In-Reply-To: <83iligsr7r.fsf@gnu.org> X-Provags-ID: V03:K1:PAOZ+xDt24A+8+hKE944pTHcq8L5T4GxQ5QAheBEcfkVuQu4MqA EARwm+REPS+mkHyAwBd3uP+lboGI4nUec9GCvM/xGydlwA4N91sz6dq+eJ+bLtAj7/GKPk5 XEG8Rvxm9JK3z0E+GX5sFUwKCeF9BeXE8UzL2hHHRlqHITvu7BNAu8CWEKbl7fvazL9YugG TW3Sy54JRZXYYOevy46bg== UI-OutboundReport: notjunk:1;M01:P0:Q8Cpv6Zsz/I=;gkjztNRg0s2Chx/L+xpgdRAoIBd zV40eWUyc9KgkMyK310vLCSBkQTQ1c3wT+X0AXwfB5z0bjIZdCrMY7O//Jb10D/ILlCmM3NzR GK7vze0MJtqrj52XNXRIe1Ngr+ixU664Fj0WBddWA6dAUK5uHaiTUIzjIR0w/JQZ9+aYZ/qYl 6Cg6xS26FqsOuzlP64VCqtmjh3RMsd5HEZ3CcwvlAa/Ydko/aSvqXQMQhMCwYQKowVqjCUU2z 45PuOn0xamD9hZHzSiikKcUSUboDwBROLNVqCC8udBOtLJWAuFc5DBI5UsNCJZcxjsgjB0ZgB 44tnBAQYFvaa+IIp/W2rcGAXqz7Pg4ewpJmTGlBe8bWh/r5B53jzkfHTqPQGdUUwSTq9W521w 2ONBXVlY3wkAJDRETem2aUX1qF8PZwCPvMPXSn7YRvo3IZnVnnXcP9KWCJK7zUv1cI2ATEYvh RTqpWeIEqNfIua8GA6I0qMoSpE3sjGrpy4ec6RXcbzfMmJJVYSIR1tLgBw3LApolvk/4ZIT7k EdfYxewo4Dq7khgKJTxB1EVW2IS0U02Rd+cvHCNMFshV5cHz61KDHM9Ywhc9ndrl34jKMSPNC 0Ab0pVJKDCnZULvNOtPW6bfmvQpGgINCLotqVCS/QVY3kkLh5xukbFbUCA5Ke3kedO+WlN+Y/ UbLuoLLiXbZQOnn7x7MjQGyWm6GEHGpEIOcNPXPbgzZO4/N89Hlt48lXydAlC7KgqQ3ItfqBH P7x9PZ+aF5RmP6vkjwElMPzCqcRJ130W/sL7VQgs6sXmrz1pFFwucp79UDTl6azVpp188EDi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250720 Archived-At: >> (let (max-chars) >> (setq right-fringe-width 0) >> (setq max-chars (window-max-chars-per-line)) >> (set-window-buffer nil (window-buffer)) >> max-chars) >> >> which currently yields 79 and would yield 80 with your proposal. > > Do we have such code somewhere? No. Fringes should be set by users only. > The correct way of doing that is to > swap the lines that call window-max-chars-per-line and > set-window-buffer, because AFAIU the latter will cause window-margins ... 'window-max-chars-per-line' I presume ... > to return the values consistent with right-fringe-width just set. My example is a simplification. There might be many more buffer-local variables to set and the conclusive 'set-window-buffer' call to put them into action might appear much later, maybe also in some other function. The simplest approach should be to put an extra (set-window-buffer nil (window-buffer)) right after the (with-selected-window (window-normalize-window window t) in 'window-max-chars-per-line'. But there's no right KEEP-MARGINS value to pass here. Maybe you should just say in the doc-string that if there are any pending buffer-local changes, they should be applied before calling 'window-max-chars-per-line'. martin