unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Jonathan Kotta <jpkotta@gmail.com>
Cc: 24126@debbugs.gnu.org
Subject: bug#24126: vc-hg-state can be extremely slow
Date: Tue, 2 Aug 2016 19:19:30 +0300	[thread overview]
Message-ID: <803901e8-fb81-82c1-647f-007bbbf7caf7@yandex.ru> (raw)
In-Reply-To: <CALDneavS7QoF+YtiW=2DvOn95KdAi3WQcz-cOdSwxXgxnWn1AA@mail.gmail.com>

On 08/02/2016 06:57 PM, Jonathan Kotta wrote:

> In the case of `vc-root-diff` at least, it's passing in a directory; the
> command is essentially `hg status -A ./`, and the CWD is indeed the repo
> root.  I did this by running `vc-root-diff` from a dired buffer visiting
> the repo root.

OK, thanks. The chain of calls looks like this:

   vc-hg-state("~/vc/mozilla-central/")
   vc-hg-registered("~/vc/mozilla-central/")
   apply(vc-hg-registered "~/vc/mozilla-central/")
   vc-call-backend(Hg registered "~/vc/mozilla-central/")
   vc-registered("~/vc/mozilla-central/")
   vc-backend("~/vc/mozilla-central/")
   vc-working-revision("~/vc/mozilla-central/")
   vc-root-diff(nil t)

Maybe vc-hg-registered shouldn't delegate to vc-hg-state, and call 'hg 
status' on its own without '-A'.





  reply	other threads:[~2016-08-02 16:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01 18:40 bug#24126: vc-hg-state can be extremely slow Jonathan Kotta
2016-08-02 13:32 ` Dmitry Gutov
2016-08-02 15:57   ` Jonathan Kotta
2016-08-02 16:19     ` Dmitry Gutov [this message]
2021-08-15 12:30       ` Lars Ingebrigtsen
2021-08-17  0:14         ` Dmitry Gutov
2021-08-18 14:39           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=803901e8-fb81-82c1-647f-007bbbf7caf7@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=24126@debbugs.gnu.org \
    --cc=jpkotta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).