From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62825: 29.0.90; c-ts-mode doesn't recognize DEFUN functions Date: Sat, 15 Apr 2023 22:37:02 -0700 Message-ID: <80353D80-21FD-4ADE-8982-4B67C59B7E7B@gmail.com> References: <831qkngdyx.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6575"; mail-complaints-to="usenet@ciao.gmane.io" Cc: theo@thornhill.no, 62825@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 16 07:38:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnv5p-0001XJ-5q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Apr 2023 07:38:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnv5W-0007xL-7Z; Sun, 16 Apr 2023 01:38:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnv5P-0007wx-7n for bug-gnu-emacs@gnu.org; Sun, 16 Apr 2023 01:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pnv5O-0002mc-EE for bug-gnu-emacs@gnu.org; Sun, 16 Apr 2023 01:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pnv5O-0003Wf-8C for bug-gnu-emacs@gnu.org; Sun, 16 Apr 2023 01:38:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <831qkngdyx.fsf@gnu.org> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Apr 2023 05:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62825 X-GNU-PR-Package: emacs Original-Received: via spool by 62825-submit@debbugs.gnu.org id=B62825.168162344313506 (code B ref 62825); Sun, 16 Apr 2023 05:38:02 +0000 Original-Received: (at 62825) by debbugs.gnu.org; 16 Apr 2023 05:37:23 +0000 Original-Received: from localhost ([127.0.0.1]:50470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnv4k-0003Vl-JS for submit@debbugs.gnu.org; Sun, 16 Apr 2023 01:37:22 -0400 Original-Received: from mail-pj1-f54.google.com ([209.85.216.54]:42568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnv4i-0003VX-9Q for 62825@debbugs.gnu.org; Sun, 16 Apr 2023 01:37:20 -0400 Original-Received: by mail-pj1-f54.google.com with SMTP id fw22-20020a17090b129600b00247255b2f40so8889708pjb.1 for <62825@debbugs.gnu.org>; Sat, 15 Apr 2023 22:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681623434; x=1684215434; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=HcNM5N6RUiQAkWK0cY8MfL0xUSwBw7TAecS5AL6ypWs=; b=Roq7rfJMISo7pH1m584hh8I7b+OM2u1Gtsu51D+6fM+W3viiKmWXIObnPHnkZ2wvKy MJ1dCE5dPFYu3hepbSBaGOCgj4phlvNfV44MEwirxncaZPy6hDNFOtpWaKmqTSXcFgSS b7TZI59HQHGnK/dFSB9HmJxoRYFrqnUVGaqtfcLDWaX3ZTzVp9432ZyV6hcAKePyx7K4 WJ+HQfbVspB8YhrYqY/TB5gLFqB6CaYQqoDVxEuZ/XMu6ftu8FaCjyz0ltIlZhKGIO/y mkByj4oDg0JrP2sq0QBCBEVWwa3HSGMTlKTMyOqa6TWbP31u40kTRIM551gnCVQh7bN4 CxNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681623434; x=1684215434; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HcNM5N6RUiQAkWK0cY8MfL0xUSwBw7TAecS5AL6ypWs=; b=lpBwlgap9T3Y0y15fZQauugWCxG3cF/PmW1LC4aEDitwOev+rP5Rm24RSb6EReLtID cXonWB6+fYqeCaX2o7gpLId+Pn21ZGk+MnKgPDLUtOqKbECeFSCewddNqcG9n+8iHTwN zIVz88ipzTULWw2e7ebVzvQILL+f8T7dgGZ4soOV5oodiVof+PW+5r6I1T+sos0H+pn5 VoTU75lOeFdabHnGScCzCpH908Hq1YF1wAjEyS0xbOG+e1iCJ35XLs2C4MjJGHuws3P0 TgWEdd3r4RnL20JeEZiBoXUcNBwny/u4WQd41Tln9FZJ8QkqRwYBfGH+15KErjOlPiPR ukOQ== X-Gm-Message-State: AAQBX9cQJfykv6YCoKK198n3f4xOQ94ISfsTSLRrQsp+dAY4FCfNTllv 7qPw6ka5FLO4t5kjIKDtNrU= X-Google-Smtp-Source: AKy350b86JHz69JueKNO4oVYjEQF8ZSA2ZuHmyfp283HWbn2JhjjXui5WjtetSTjhwLz/x4bF6oK1Q== X-Received: by 2002:a17:902:e747:b0:1a6:6090:7114 with SMTP id p7-20020a170902e74700b001a660907114mr9858829plf.69.1681623434542; Sat, 15 Apr 2023 22:37:14 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 6-20020a170902c20600b001a6d08dc847sm244505pll.173.2023.04.15.22.37.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Apr 2023 22:37:14 -0700 (PDT) X-Mailer: Apple Mail (2.3731.500.231) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260090 Archived-At: Eli Zaretskii writes: >> From: Yuan Fu >> Date: Fri, 14 Apr 2023 13:19:41 -0700 >> Cc: Theodor Thornhill , >> 62825@debbugs.gnu.org >>=20 >> Ok, I fixed indent-defund and add-log. Because a DEFUN is made of >> two nodes in the parse tree rather than one, it=E2=80=99s a bit hard = to >> incorporate it into the normal treesit-defun-at-point, etc, >> functions. And we probably have to fix DEFUN case-by-case. > > Thanks. But I wonder why do we need the c-ts-mode-emacs-devel knob. > Why not recognize DEFUN by default everywhere? CC Mode does that, > AFAIK, so why shouldn't c-ts-mode do the same? I just thought the fix is a bit hacky, and does add some overhead, so people who don=E2=80=99t need it might not be happy to know that they = can=E2=80=99t turn it off. Yuan