bug#10702: 24.0.92; broken widget in Man

bug#10702: 24.0.92; broken widget in Man

[Sam Steingold]

In GNU Emacs 24.0.92.8 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2012-01-24 on t520sds
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
configured using `configure  '--with-wide-int''

emacs -Q
M-x man RET
2 stat RET
navigate to <sys/stat.h> and hit RET or mouse2 on it
==>

Debugger entered--Lisp error: (error #("Cannot find header file: sys/stat.h" 25 26 (face bold) 26 27 (face bold) 27 28 (face bold) 28 29 (face bold) 29 30 (face bold) 30 31 (face bold) 31 32 (face bold) 32 33 (face bold) 33 34 (face bold) 34 35 (face bold)))
  signal(error (#("Cannot find header file: sys/stat.h" 25 26 (face bold) 26 27 (face bold) 27 28 (face bold) 28 29 (face bold) 29 30 (face bold) 30 31 (face bold) 31 32 (face bold) 32 33 (face bold) 33 34 (face bold) 34 35 (face bold))))
  error("Cannot find header file: %s" #("sys/stat.h" 0 1 (face bold) 1 2 (face bold) 2 3 (face bold) 3 4 (face bold) 4 5 (face bold) 5 6 (face bold) 6 7 (face bold) 7 8 (face bold) 8 9 (face bold) 9 10 (face bold)))
  #[(button) "\302\b\303\".\304	!?\205.

bug#10702: 24.0.92; broken widget in Man

[Glenn Morris]

Sam Steingold wrote:

> emacs -Q
> M-x man RET
> 2 stat RET
> navigate to <sys/stat.h> and hit RET or mouse2 on it
> ==>
>
> Debugger entered--Lisp error: (error #("Cannot find header file: sys/stat.h" 25 26 (face bold) 26 27 (face bold) 27 28 (face bold) 28 29 (face bold) 29 30 (face bold) 30 31 (face bold) 31 32 (face bold) 32 33 (face bold) 33 34 (face bold) 34 35 (face bold)))

I can't reproduce this in the current trunk.
If /usr/include/sys/stat.h is present I warp to it, if not then
I just get the expected error message as shown above: Cannot find header file:
sys/stat.h.

Do you have a readable sys/stat.h somewhere in Man-header-file-path on
your system?

bug#10702: 24.0.92; broken widget in Man

[Glenn Morris]

I'm going to take a guess that you don't in fact have a
/usr/include/sys/stat.h file on your system, because you are using a
multi-arch system where this file has moved to eg

/usr/include/x86_64-linux-gnu/sys/stat.h

I don't know how many possible architecture locations exist, but
I guess it would do no harm to add them all to Man-header-file-path,
since only one is likely to exist on most systems.

bug#10702: 24.0.92; broken widget in Man

[Glenn Morris]

Glenn Morris wrote:

> I don't know how many possible architecture locations exist,

There seems to be a ridiculous number of possibilities:

http://wiki.debian.org/Multiarch/Tuples

I suggest something like this instead:

(defcustom Man-header-file-path
  (let ((arch (with-temp-buffer
                (when (eq 0 (ignore-errors
                              (call-process "gcc" nil '(t nil) nil
                                            "-print-multiarch")))
                  (goto-char (point-min))
                  (buffer-substring (point) (line-end-position)))))
        (base '("/usr/include" "/usr/local/include")))
    (if (zerop (length arch))
        base
      (append base (list (expand-file-name arch "/usr/include")))))
  "C Header file search path used in Man."
  :type '(repeat string)
  :version "24.1"                       ; add multiarch
  :group 'man)


There seem to be a few other places in Emacs that use usr/include (eg
ffap-c-path), so perhaps this should be centralized somewhere.

bug#10702: 24.0.92; broken widget in Man

[Stefan Monnier]

>> I don't know how many possible architecture locations exist,

> There seems to be a ridiculous number of possibilities:
> http://wiki.debian.org/Multiarch/Tuples
> I suggest something like this instead:

> (defcustom Man-header-file-path
>   (let ((arch (with-temp-buffer
>                 (when (eq 0 (ignore-errors
>                               (call-process "gcc" nil '(t nil) nil
>                                             "-print-multiarch")))
>                   (goto-char (point-min))
>                   (buffer-substring (point) (line-end-position)))))
>         (base '("/usr/include" "/usr/local/include")))
>     (if (zerop (length arch))
>         base
>       (append base (list (expand-file-name arch "/usr/include")))))
>   "C Header file search path used in Man."
>   :type '(repeat string)
>   :version "24.1"                       ; add multiarch
>   :group 'man)

Sounds about right, yes.

> There seem to be a few other places in Emacs that use usr/include (eg
> ffap-c-path), so perhaps this should be centralized somewhere.

Yes, after 24.1,


        Stefan

bug#10702: 24.0.92; broken widget in Man

[Glenn Morris]

Stefan Monnier wrote:

>> There seem to be a few other places in Emacs that use usr/include (eg
>> ffap-c-path), so perhaps this should be centralized somewhere.
>
> Yes, after 24.1,

OK. Do you want some, all, or none of the following individual users
fixing for 24.1?

Man-header-file-path
cc-search-directories
ffap-c-path
semantic-c-dependency-system-include-path
semantic-gcc-setup

bug#10702: 24.0.92; broken widget in Man

[Stefan Monnier]

>>> There seem to be a few other places in Emacs that use usr/include (eg
>>> ffap-c-path), so perhaps this should be centralized somewhere.
>> Yes, after 24.1,
> OK. Do you want some, all, or none of the following individual users
> fixing for 24.1?
> Man-header-file-path
> cc-search-directories
> ffap-c-path
> semantic-c-dependency-system-include-path
> semantic-gcc-setup

I'd recommend not to touch the semantic-*.
And I wouldn't bother with cc-search-directories which doesn't even bother
to obey the prefix naming convention.
So if you can fix the remaining two, with a clear comment about the
duplication and need for unification, then that'd be wonderful,


        Stefan

bug#10702: 24.0.92; broken widget in Man

[Glenn Morris]

Version: 24.0.94

Fixed Man-header-file-path.