From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#13432: 24.2; File does not get saved when save-buffer called Date: Sun, 13 Jan 2013 19:54:29 -0500 Message-ID: <7qwqvglh2y.fsf@fencepost.gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1358124901 6329 80.91.229.3 (14 Jan 2013 00:55:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 14 Jan 2013 00:55:01 +0000 (UTC) Cc: 13432@debbugs.gnu.org To: Peter Milliken Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 14 01:55:18 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TuYKW-0002re-GL for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Jan 2013 01:55:12 +0100 Original-Received: from localhost ([::1]:39929 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuYKG-0003lA-8u for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Jan 2013 19:54:56 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:46010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuYKA-0003ke-Sq for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 19:54:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuYK2-0005tI-6N for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 19:54:50 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuYK2-0005tD-34 for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 19:54:42 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TuYKM-0000F1-Hc for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 19:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Jan 2013 00:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13432 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13432-submit@debbugs.gnu.org id=B13432.1358124896914 (code B ref 13432); Mon, 14 Jan 2013 00:55:02 +0000 Original-Received: (at 13432) by debbugs.gnu.org; 14 Jan 2013 00:54:56 +0000 Original-Received: from localhost ([127.0.0.1]:58860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TuYKF-0000Eg-DA for submit@debbugs.gnu.org; Sun, 13 Jan 2013 19:54:55 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:42514 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TuYKD-0000EZ-3J for 13432@debbugs.gnu.org; Sun, 13 Jan 2013 19:54:54 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TuYJq-0008KM-8y; Sun, 13 Jan 2013 19:54:30 -0500 X-Spook: warfare Clinton unclassified Mafia condor Firewalls NATO X-Ran: O=VdD&f!L"tw`b(_+\Tf93L'=+%B&7Sct@bBq{g8-8Gv_Z&p_D8@;I@(&^yxdlqenuo2R. X-Hue: cyan X-Attribution: GM In-Reply-To: (Peter Milliken's message of "Mon, 14 Jan 2013 09:40:55 +1100") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69741 Archived-At: Peter Milliken wrote: > This behaviour started with Emacs 24.1 - it does not happen on earlier > versions. > > In my .emacs I defadvice several major modes to include a call to > untabify in the local-write-file-hooks. With this version of Emacs, the > defadvice > seems to trigger a bug where the message line states the file has been > saved when it has not been saved - the status line indicates it is still > in a modified state as well. > > Minimal/sample code that triggers/illustrates this bug is: > > (defadvice python-mode (after minor-modes-for-python activate compile) > (add-hook 'local-write-file-hooks '(lambda () (untabify (point-min) > (point-max))))) Please read the doc of local-write-file-hooks: This variable is obsolete since 22.1; use `write-file-functions' instead. >From write-file-functions: If one of them returns non-nil, the file is considered already written ^^^^^^^^^^^^^^^^^^^^^^^^^^ and the rest are not called. So: ensure that any functions you add return nil. The return value of untabify is unspecfied (ie, could be anything).