* bug#18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook
@ 2014-11-03 15:00 xristos
2014-11-04 20:08 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: xristos @ 2014-11-03 15:00 UTC (permalink / raw)
To: 18936
From erc.el, erc-send-pre-hook documentation:
"To change the text that will be sent, set the variable STR which is
used in `erc-send-current-line'."
From erc.el:5272, function `erc-send-input'
(let ((str input)
(erc-insert-this t))
(setq erc-send-this t)
(run-hook-with-args 'erc-send-pre-hook input)
STR is dynamically bound.
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook
2014-11-03 15:00 bug#18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook xristos
@ 2014-11-04 20:08 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2014-11-04 20:08 UTC (permalink / raw)
To: xristos; +Cc: 18936-done
> From erc.el, erc-send-pre-hook documentation:
> "To change the text that will be sent, set the variable STR which is
> used in `erc-send-current-line'."
Indeed. I installed the patch below which should fix it.
Stefan
=== modified file 'lisp/erc/erc.el'
--- lisp/erc/erc.el 2014-02-10 01:34:22 +0000
+++ lisp/erc/erc.el 2014-11-04 20:06:00 +0000
@@ -5268,6 +5268,7 @@
(beep))
nil)
(t
+ (defvar str) ;; FIXME: Make it obey the "erc-" prefix convention.
(let ((str input)
(erc-insert-this t))
(setq erc-send-this t)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-04 20:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-03 15:00 bug#18936: ERC: lexical-binding in 24.4 breaks erc-send-pre-hook xristos
2014-11-04 20:08 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).